-
Notifications
You must be signed in to change notification settings - Fork 677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(perception_rviz_plugin): rviz object covariances #6074
feat(perception_rviz_plugin): rviz object covariances #6074
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
cdce2e7
to
fd81b7f
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6074 +/- ##
==========================================
- Coverage 14.66% 14.63% -0.03%
==========================================
Files 1858 1858
Lines 126603 126811 +208
Branches 37157 37157
==========================================
Hits 18564 18564
- Misses 87167 87375 +208
Partials 20872 20872
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…tion#6074) * feat: visualize yaw rate, yaw std Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * feat: discrete yaw covariance marker Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * feat: add yaw covariance to detected object Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * feat: visualize twist covariance, yaw only Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * feat: discrete yaw rate marker Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: property order Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * chore: parameter order change Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * feat: position covariance as ellipse Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * feat: twist covariance Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * chore: pose covariance marker renamed Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: velocity covariance minimum alpha Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * chore: refactoring Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * feat: add option for interval coefficients Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: confidence interval (1D) and confidence region (2D) Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> --------- Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
…tion#6074) * feat: visualize yaw rate, yaw std Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * feat: discrete yaw covariance marker Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * feat: add yaw covariance to detected object Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * feat: visualize twist covariance, yaw only Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * feat: discrete yaw rate marker Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: property order Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * chore: parameter order change Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * feat: position covariance as ellipse Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * feat: twist covariance Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * chore: pose covariance marker renamed Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: velocity covariance minimum alpha Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * chore: refactoring Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * feat: add option for interval coefficients Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: confidence interval (1D) and confidence region (2D) Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> --------- Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
…tion#6074) * feat: visualize yaw rate, yaw std Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * feat: discrete yaw covariance marker Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * feat: add yaw covariance to detected object Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * feat: visualize twist covariance, yaw only Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * feat: discrete yaw rate marker Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: property order Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * chore: parameter order change Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * feat: position covariance as ellipse Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * feat: twist covariance Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * chore: pose covariance marker renamed Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: velocity covariance minimum alpha Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * chore: refactoring Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * feat: add option for interval coefficients Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: confidence interval (1D) and confidence region (2D) Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> --------- Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
…tion#6074) * feat: visualize yaw rate, yaw std Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * feat: discrete yaw covariance marker Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * feat: add yaw covariance to detected object Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * feat: visualize twist covariance, yaw only Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * feat: discrete yaw rate marker Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: property order Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * chore: parameter order change Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * feat: position covariance as ellipse Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * feat: twist covariance Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * chore: pose covariance marker renamed Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: velocity covariance minimum alpha Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * chore: refactoring Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * feat: add option for interval coefficients Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: confidence interval (1D) and confidence region (2D) Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> --------- Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Description
Modify pose covariance to draw eclipse instead of cross. (white eclipse)
Add visualizations of
Yaw Covariance (white section)
Twist Covariance (red eclipse)
Yaw Rate (red section)
Yaw Rate Covariance (pink H-shape)
Related links
Tests performed
rviz-plugin-object-covariances2.mp4
Notes for reviewers
false
. It is to reduce complexity of default view.covariance
was inherited. The visualizations ofcovariance
is the confidence interval.Interface changes
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.