Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(perception_rviz_plugin): rviz object covariances #6074

Merged

Conversation

technolojin
Copy link
Contributor

@technolojin technolojin commented Jan 15, 2024

Description

  1. Modify pose covariance to draw eclipse instead of cross. (white eclipse)
    Screenshot from 2024-01-15 10-17-48

  2. Add visualizations of

  • Yaw Covariance (white section)
    Screenshot from 2024-01-15 10-18-25

  • Twist Covariance (red eclipse)
    Screenshot from 2024-01-15 10-18-48

  • Yaw Rate (red section)
    Screenshot from 2024-01-15 10-20-03

  • Yaw Rate Covariance (pink H-shape)
    Screenshot from 2024-01-15 10-20-33

  1. Add option to configure confidence Interval of 'Covariance'

Related links

Tests performed

rviz-plugin-object-covariances2.mp4

Notes for reviewers

  • Default value of the new visualizations are false. It is to reduce complexity of default view.
  • Naming convention of covariance was inherited. The visualizations of covariance is the confidence interval.

Interface changes

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@technolojin technolojin self-assigned this Jan 15, 2024
@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Jan 15, 2024
@technolojin technolojin marked this pull request as ready for review January 15, 2024 04:23
Copy link
Contributor

@taikitanaka3 taikitanaka3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
@technolojin technolojin force-pushed the feat/rviz-object-covariances branch from cdce2e7 to fd81b7f Compare January 16, 2024 00:37
@technolojin technolojin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 16, 2024
@technolojin technolojin enabled auto-merge (squash) January 16, 2024 01:23
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 250 lines in your changes are missing coverage. Please review.

Comparison is base (6e550fc) 14.66% compared to head (fd81b7f) 14.63%.
Report is 3 commits behind head on main.

Files Patch % Lines
...gin/src/object_detection/object_polygon_detail.cpp 0.00% 150 Missing ⚠️
...n/object_detection/object_polygon_display_base.hpp 0.00% 31 Missing ⚠️
...src/object_detection/predicted_objects_display.cpp 0.00% 24 Missing ⚠️
...n/src/object_detection/tracked_objects_display.cpp 0.00% 24 Missing ⚠️
.../src/object_detection/detected_objects_display.cpp 0.00% 21 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6074      +/-   ##
==========================================
- Coverage   14.66%   14.63%   -0.03%     
==========================================
  Files        1858     1858              
  Lines      126603   126811     +208     
  Branches    37157    37157              
==========================================
  Hits        18564    18564              
- Misses      87167    87375     +208     
  Partials    20872    20872              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 14.66% <ø> (+<0.01%) ⬆️ Carriedforward from 6e550fc

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@technolojin technolojin merged commit c52d091 into autowarefoundation:main Jan 16, 2024
29 of 33 checks passed
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
…tion#6074)

* feat: visualize yaw rate, yaw std

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* feat: discrete yaw covariance marker

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* feat: add yaw covariance to detected object

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* feat: visualize twist covariance, yaw only

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* feat: discrete yaw rate marker

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* fix: property order

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* chore: parameter order change

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* feat: position covariance as ellipse

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* feat: twist covariance

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* chore: pose covariance marker renamed

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* fix: velocity covariance minimum alpha

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* chore: refactoring

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* feat: add option for interval coefficients

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* fix: confidence interval (1D) and confidence region (2D)

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

---------

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…tion#6074)

* feat: visualize yaw rate, yaw std

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* feat: discrete yaw covariance marker

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* feat: add yaw covariance to detected object

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* feat: visualize twist covariance, yaw only

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* feat: discrete yaw rate marker

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* fix: property order

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* chore: parameter order change

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* feat: position covariance as ellipse

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* feat: twist covariance

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* chore: pose covariance marker renamed

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* fix: velocity covariance minimum alpha

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* chore: refactoring

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* feat: add option for interval coefficients

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* fix: confidence interval (1D) and confidence region (2D)

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

---------

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…tion#6074)

* feat: visualize yaw rate, yaw std

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* feat: discrete yaw covariance marker

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* feat: add yaw covariance to detected object

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* feat: visualize twist covariance, yaw only

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* feat: discrete yaw rate marker

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* fix: property order

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* chore: parameter order change

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* feat: position covariance as ellipse

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* feat: twist covariance

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* chore: pose covariance marker renamed

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* fix: velocity covariance minimum alpha

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* chore: refactoring

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* feat: add option for interval coefficients

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* fix: confidence interval (1D) and confidence region (2D)

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

---------

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…tion#6074)

* feat: visualize yaw rate, yaw std

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* feat: discrete yaw covariance marker

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* feat: add yaw covariance to detected object

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* feat: visualize twist covariance, yaw only

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* feat: discrete yaw rate marker

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* fix: property order

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* chore: parameter order change

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* feat: position covariance as ellipse

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* feat: twist covariance

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* chore: pose covariance marker renamed

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* fix: velocity covariance minimum alpha

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* chore: refactoring

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* feat: add option for interval coefficients

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* fix: confidence interval (1D) and confidence region (2D)

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

---------

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
@technolojin technolojin deleted the feat/rviz-object-covariances branch July 26, 2024 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants