refactor(start_planner): separate start planner parameters and debug data structure #6101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:planning
kyoichi-sugahara
changed the title
kyoichi-sugahara
requested review from
kosuke55,
satoshi-ota,
shmpwk,
TomohitoAndo,
tkimura4,
danielsanchezaran,
rej55,
soblin,
maxime-clem,
TakaHoribe,
takayuki5168 and
zulfaqar-azmi-t4
as code owners
kyoichi-sugahara
added
the
run:build-and-test-differential
kyoichi-sugahara
force-pushed
the
refactor/separate_start_planner_parameters
branch
from
72322af to
f75dab6
Compare
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
kyoichi-sugahara
force-pushed
the
refactor/separate_start_planner_parameters
branch
from
f75dab6 to
4c4e62a
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6101 +/- ##
==========================================
+ Coverage 14.62% 14.63% +0.01%
==========================================
Files 1860 1859 -1
Lines 127172 127063 -109
Branches 37229 37224 -5
==========================================
Hits 18596 18596
+ Misses 87660 87552 -108
+ Partials 20916 20915 -1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
kosuke55
reviewed
Jan 18, 2024
...havior_path_start_planner_module/include/behavior_path_start_planner_module/data_structs.hpp
Show resolved
Hide resolved
...ath_start_planner_module/include/behavior_path_start_planner_module/start_planner_module.hpp
Outdated
Show resolved
Hide resolved
...ath_start_planner_module/include/behavior_path_start_planner_module/start_planner_module.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
kosuke55
approved these changes
Jan 18, 2024
kyoichi-sugahara
merged commit 9b03b23
into
autowarefoundation:main
24 of 26 checks passed
kyoichi-sugahara
deleted the
refactor/separate_start_planner_parameters
branch
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 26, 2024
…data structure (autowarefoundation#6101) * Add data_structs.hpp and update include paths * Refactor start planner debug data structure * Update debug_data variable name in StartPlannerModule Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> --------- Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
…data structure (autowarefoundation#6101) * Add data_structs.hpp and update include paths * Refactor start planner debug data structure * Update debug_data variable name in StartPlannerModule Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> --------- Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: karishma <karishma@interpl.ai>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
…data structure (autowarefoundation#6101) * Add data_structs.hpp and update include paths * Refactor start planner debug data structure * Update debug_data variable name in StartPlannerModule Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> --------- Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…data structure (autowarefoundation#6101) * Add data_structs.hpp and update include paths * Refactor start planner debug data structure * Update debug_data variable name in StartPlannerModule Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> --------- Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
satoshi-ota
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Jun 6, 2024
…data structure (autowarefoundation#6101) * Add data_structs.hpp and update include paths * Refactor start planner debug data structure * Update debug_data variable name in StartPlannerModule Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> --------- Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
separate start planner parameters and debug data structure
Tests performed
test with psim
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.