-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(map_launch): use map.launch.xml instead of map.launch.py #6185
refactor(map_launch): use map.launch.xml instead of map.launch.py #6185
Conversation
Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>
@reviewers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙆♂️ I have confirmed it works well with the following steps.
# show map node
$ ros2 node list |grep /map
# /map/lanelet2_map_loader
# /map/lanelet2_map_visualization
# /map/map_container
# /map/map_hash_generator
# /map/map_projection_loader
# /map/pointcloud_map_loader
# /map/vector_map_tf_generator
# kill map_container
$ pgrep -f map_container | awk '{print "kill", $1}' | bash
# show ros node again
$ ros2 node list |grep /map
# /map/map_hash_generator
# /map/map_projection_loader
Also, I did not find any differences from the original map.launch.py.
…towarefoundation#6185) * refactor(map_launch): use map.launch.xml instead of map.launch.py Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * style(pre-commit): autofix --------- Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Merge with autowarefoundation/autoware_launch#826
Description
use map.launch.xml instead of map.launch.py.
Tests performed
LSim works
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.