Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(map_launch): use map.launch.xml instead of map.launch.py #6185

Merged

Conversation

YamatoAndo
Copy link
Contributor

@YamatoAndo YamatoAndo commented Jan 26, 2024

Merge with autowarefoundation/autoware_launch#826

Description

use map.launch.xml instead of map.launch.py.

Tests performed

LSim works

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>
@github-actions github-actions bot added the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Jan 26, 2024
@YamatoAndo
Copy link
Contributor Author

YamatoAndo commented Jan 26, 2024

@reviewers
I believe I have modified map.launch.xml to behave the same as map.launch.py.
If there are any differences, please let me know in the comments.

Copy link
Contributor

@KYabuuchi KYabuuchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙆‍♂️ I have confirmed it works well with the following steps.

# show map node
$ ros2 node list |grep /map
#    /map/lanelet2_map_loader
#    /map/lanelet2_map_visualization
#    /map/map_container
#    /map/map_hash_generator
#    /map/map_projection_loader
#    /map/pointcloud_map_loader
#    /map/vector_map_tf_generator

# kill map_container
$ pgrep -f map_container | awk '{print "kill", $1}' | bash 

# show ros node again
$ ros2 node list |grep /map
#    /map/map_hash_generator
#    /map/map_projection_loader

Also, I did not find any differences from the original map.launch.py.

@YamatoAndo YamatoAndo added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 26, 2024
@YamatoAndo YamatoAndo merged commit ef7a2b9 into autowarefoundation:main Jan 30, 2024
28 of 29 checks passed
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…towarefoundation#6185)

* refactor(map_launch): use map.launch.xml instead of map.launch.py

Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants