Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(trajectory_follower_nodes): switch to isolated gtests #661

Merged
merged 1 commit into from
Apr 12, 2022

Conversation

maxime-clem
Copy link
Contributor

@maxime-clem maxime-clem commented Apr 8, 2022

Description

This PR attempts to fix #649 by running tests of package trajectory_follower_nodes in "isolated" mode.

Such solution has been investigated before: https://gitlab.com/autowarefoundation/autoware.auto/AutowareAuto/-/issues/1470

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@maxime-clem maxime-clem added the type:new-feature New functionalities or additions, feature requests. label Apr 8, 2022
@maxime-clem maxime-clem self-assigned this Apr 8, 2022
@maxime-clem maxime-clem force-pushed the 649-fix-flaky-trajectory_follower_test branch from dec2d38 to 27664e1 Compare April 8, 2022 11:06
@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #661 (1816f45) into main (dc682e6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #661   +/-   ##
=======================================
  Coverage   10.59%   10.59%           
=======================================
  Files         734      734           
  Lines       51719    51719           
  Branches     6596     6596           
=======================================
  Hits         5482     5482           
  Misses      41777    41777           
  Partials     4460     4460           
Flag Coverage Δ *Carryforward flag
differential 35.34% <ø> (?)
total 10.59% <ø> (ø) Carriedforward from dc682e6

*This pull request uses carry forward flags. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc682e6...1816f45. Read the comment docs.

@maxime-clem maxime-clem marked this pull request as ready for review April 12, 2022 07:53
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem maxime-clem force-pushed the 649-fix-flaky-trajectory_follower_test branch from 27664e1 to 1816f45 Compare April 12, 2022 07:53
@maxime-clem maxime-clem merged commit f08233a into main Apr 12, 2022
@maxime-clem maxime-clem deleted the 649-fix-flaky-trajectory_follower_test branch April 12, 2022 10:28
@maxime-clem maxime-clem mentioned this pull request Apr 12, 2022
3 tasks
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
soblin pushed a commit to soblin/autoware.universe that referenced this pull request Jul 25, 2023
* update

Signed-off-by: yutaka <purewater0901@gmail.com>

* update

Signed-off-by: yutaka <purewater0901@gmail.com>

* update

Signed-off-by: yutaka <purewater0901@gmail.com>

* update

Signed-off-by: yutaka <purewater0901@gmail.com>

* fix(lane_change): fix activation timing of the  passParkedObject funtion (autowarefoundation#4239)

fix(lane_change): fix activation timing of the  passParkedObject function

Signed-off-by: yutaka <purewater0901@gmail.com>

* update

Signed-off-by: yutaka <purewater0901@gmail.com>

---------

Signed-off-by: yutaka <purewater0901@gmail.com>
Co-authored-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>
Co-authored-by: Zulfaqar Azmi <93502286+zulfaqar-azmi-t4@users.noreply.github.com>
iwatake2222 pushed a commit to iwatake2222/autoware.universe that referenced this pull request Jan 17, 2025
Kazunori-Nakajima pushed a commit to Kazunori-Nakajima/autoware.universe that referenced this pull request Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:new-feature New functionalities or additions, feature requests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sometimes trajectory_follower's test fails with ARM64
2 participants