Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(route_handler): planning route with goal lanelet in candidate_lanelets #6802

Closed
wants to merge 4 commits into from

Merge branch 'main' into fix-route-handler

c958d24
Select commit
Loading
Failed to load commit list.
Closed

fix(route_handler): planning route with goal lanelet in candidate_lanelets #6802

Merge branch 'main' into fix-route-handler
c958d24
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Apr 17, 2024 in 37s

CodeScene PR Check

Code Health Quality Gates: OK

  • Improving Code Health: 2 findings(s) ✅

View detailed results in CodeScene

Details

✅ Improving Code Health:

  • Overall Code Complexity route_handler.cpp
  • Complex Method route_handler.cpp: RouteHandler::getLaneletSequenceUpTo

Annotations

Check notice on line 596 in planning/route_handler/src/route_handler.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

✅ Getting better: Complex Method

RouteHandler::getLaneletSequenceUpTo decreases in cyclomatic complexity from 15 to 14, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check notice on line 1 in planning/route_handler/src/route_handler.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

✅ Getting better: Overall Code Complexity

The mean cyclomatic complexity decreases from 4.50 to 4.49, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.