feat!: replace autoware_auto_msgs with autoware_msgs for evaluator modules #7241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitsudome-r
requested review from
kyoichi-sugahara,
maxime-clem,
rej55,
kosuke55,
ktro2828,
miursh,
YoshiRi,
djargot,
kminoda,
satoshi-ota,
shmpwk,
TakaHoribe,
takayuki5168 and
tkimura4
as code owners
github-actions
bot
added
type:documentation
xmfcx
added
run:build-and-test-differential
…dules Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp> Co-authored-by: Cynthia Liu <cynthia.liu@autocore.ai> Co-authored-by: NorahXiong <norah.xiong@autocore.ai> Co-authored-by: beginningfan <beginning.fan@autocore.ai>
xmfcx
force-pushed
the
autoware_msg_evaluator
branch
from
9d1355f to
47aee72
Compare
xmfcx
approved these changes
Jun 4, 2024
There was a problem hiding this comment.
colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=RelWithDebInfo -DCMAKE_EXPORT_COMPILE_COMMANDS=1 --packages-up-to control_evaluator diagnostic_converter kinematic_evaluator localization_evaluator perception_online_evaluator planning_evaluator
compiles successfully.
No autoware_auto references were left.
a-maumau
pushed a commit
to a-maumau/autoware.universe
that referenced
this pull request
Jun 7, 2024
…dules (autowarefoundation#7241) Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp> Co-authored-by: Cynthia Liu <cynthia.liu@autocore.ai> Co-authored-by: NorahXiong <norah.xiong@autocore.ai> Co-authored-by: beginningfan <beginning.fan@autocore.ai>
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
…dules (#7241) Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp> Co-authored-by: Cynthia Liu <cynthia.liu@autocore.ai> Co-authored-by: NorahXiong <norah.xiong@autocore.ai> Co-authored-by: beginningfan <beginning.fan@autocore.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is subset of #6893 to make it easier to review.
This includes all the modification for
evaluatordirectory in the original PR.Related links
#6893
https://github.com/orgs/autowarefoundation/discussions/3862
Tests performed
Notes for reviewers
Interface changes
Message types are modified according to the table in this comment.
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.