-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(static_obstacle_avoidance): organize params for drivable lane #7715
refactor(static_obstacle_avoidance): organize params for drivable lane #7715
Conversation
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
"use_lane_type": { | ||
"type": "string", | ||
"enum": ["current_lane", "same_direction_lane", "opposite_direction_lane"], | ||
"description": "Drivable lane configuration.", | ||
"default": "true" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"default": "true" | |
"default": "current_lane" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahhhhhhhh.....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed it in 65ace5a.
..._behavior_path_static_obstacle_avoidance_module/schema/static_obstacle_avoidance.schema.json
Outdated
Show resolved
Hide resolved
…bstacle_avoidance_module/schema/static_obstacle_avoidance.schema.json
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7715 +/- ##
===========================================
- Coverage 14.84% 13.66% -1.19%
===========================================
Files 1999 255 -1744
Lines 139163 26592 -112571
Branches 43716 5169 -38547
===========================================
- Hits 20661 3633 -17028
+ Misses 95731 22430 -73301
+ Partials 22771 529 -22242
☔ View full report in Codecov by Sentry. |
autowarefoundation#7715) * refactor(static_obstacle_avoidance): organize params for drivable lane Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * Update planning/behavior_path_planner/autoware_behavior_path_static_obstacle_avoidance_module/schema/static_obstacle_avoidance.schema.json --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
autowarefoundation#7715) * refactor(static_obstacle_avoidance): organize params for drivable lane Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * Update planning/behavior_path_planner/autoware_behavior_path_static_obstacle_avoidance_module/schema/static_obstacle_avoidance.schema.json --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
autowarefoundation#7715) * refactor(static_obstacle_avoidance): organize params for drivable lane Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * Update planning/behavior_path_planner/autoware_behavior_path_static_obstacle_avoidance_module/schema/static_obstacle_avoidance.schema.json --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Signed-off-by: palas21 <palas21@itu.edu.tr>
autowarefoundation#7715) * refactor(static_obstacle_avoidance): organize params for drivable lane Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * Update planning/behavior_path_planner/autoware_behavior_path_static_obstacle_avoidance_module/schema/static_obstacle_avoidance.schema.json --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
#7715) * refactor(static_obstacle_avoidance): organize params for drivable lane Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * Update planning/behavior_path_planner/autoware_behavior_path_static_obstacle_avoidance_module/schema/static_obstacle_avoidance.schema.json --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
autowarefoundation#7715) * refactor(static_obstacle_avoidance): organize params for drivable lane Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * Update planning/behavior_path_planner/autoware_behavior_path_static_obstacle_avoidance_module/schema/static_obstacle_avoidance.schema.json --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Description
We don't expect to set params for drivable lane as follow:
However, we were able to do that in previous config structure.
I fixed it to prevent unexpected paramter configuration.
Related links
Parent Issue:
How was this PR tested?
Psim
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.