Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(static_obstacle_avoidance): organize params for drivable lane #7715

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Jun 27, 2024

Description

We don't expect to set params for drivable lane as follow:

use_adjacent_lane: false
use_opposite_lane: true

However, we were able to do that in previous config structure.

I fixed it to prevent unexpected paramter configuration.

Related links

Parent Issue:

⚠️ Please approve this PR at first.

How was this PR tested?

Psim

      # drivable lane setting. this module is able to use not only current lane but also right/left lane
      # if the current lane(=lanelt::Lanelet) and the rignt/left lane share the boundary(=lanelet::Linestring) in HDMap.
      # "current_lane"           : use only current lane. this module doesn't use adjacent lane to avoid object.
      # "same_direction_lane"    : this module uses same direction lane to avoid object if need.
      # "opposite_direction_lane": this module uses both same direction and opposite direction lane.
      use_lane_type: "same_direction_lane"

Screenshot from 2024-06-27 10-25-43

      # drivable lane setting. this module is able to use not only current lane but also right/left lane
      # if the current lane(=lanelt::Lanelet) and the rignt/left lane share the boundary(=lanelet::Linestring) in HDMap.
      # "current_lane"           : use only current lane. this module doesn't use adjacent lane to avoid object.
      # "same_direction_lane"    : this module uses same direction lane to avoid object if need.
      # "opposite_direction_lane": this module uses both same direction and opposite direction lane.
      use_lane_type: "opposite_direction_lane"

Screenshot from 2024-06-27 10-22-50

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Copy link

github-actions bot commented Jun 27, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Jun 27, 2024
"use_lane_type": {
"type": "string",
"enum": ["current_lane", "same_direction_lane", "opposite_direction_lane"],
"description": "Drivable lane configuration.",
"default": "true"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"default": "true"
"default": "current_lane"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhhhhhhh.....

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed it in 65ace5a.

…bstacle_avoidance_module/schema/static_obstacle_avoidance.schema.json
@satoshi-ota satoshi-ota added run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) labels Jun 27, 2024
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 13.66%. Comparing base (507e3f4) to head (65ace5a).
Report is 156 commits behind head on main.

Files Patch % Lines
...ath_static_obstacle_avoidance_module/src/utils.cpp 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #7715       +/-   ##
===========================================
- Coverage   14.84%   13.66%    -1.19%     
===========================================
  Files        1999      255     -1744     
  Lines      139163    26592   -112571     
  Branches    43716     5169    -38547     
===========================================
- Hits        20661     3633    -17028     
+ Misses      95731    22430    -73301     
+ Partials    22771      529    -22242     
Flag Coverage Δ
differential 13.66% <80.00%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@satoshi-ota satoshi-ota merged commit 228b6af into autowarefoundation:main Jun 27, 2024
51 of 52 checks passed
@satoshi-ota satoshi-ota deleted the refactor/avoidance-param branch June 27, 2024 03:47
mitukou1109 pushed a commit to mitukou1109/autoware.universe that referenced this pull request Jul 2, 2024
autowarefoundation#7715)

* refactor(static_obstacle_avoidance): organize params for drivable lane

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* Update planning/behavior_path_planner/autoware_behavior_path_static_obstacle_avoidance_module/schema/static_obstacle_avoidance.schema.json

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Jul 8, 2024
autowarefoundation#7715)

* refactor(static_obstacle_avoidance): organize params for drivable lane

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* Update planning/behavior_path_planner/autoware_behavior_path_static_obstacle_avoidance_module/schema/static_obstacle_avoidance.schema.json

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
palas21 pushed a commit to palas21/autoware.universe that referenced this pull request Jul 12, 2024
autowarefoundation#7715)

* refactor(static_obstacle_avoidance): organize params for drivable lane

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* Update planning/behavior_path_planner/autoware_behavior_path_static_obstacle_avoidance_module/schema/static_obstacle_avoidance.schema.json

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: palas21 <palas21@itu.edu.tr>
tby-udel pushed a commit to tby-udel/autoware.universe that referenced this pull request Jul 14, 2024
autowarefoundation#7715)

* refactor(static_obstacle_avoidance): organize params for drivable lane

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* Update planning/behavior_path_planner/autoware_behavior_path_static_obstacle_avoidance_module/schema/static_obstacle_avoidance.schema.json

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
#7715)

* refactor(static_obstacle_avoidance): organize params for drivable lane

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* Update planning/behavior_path_planner/autoware_behavior_path_static_obstacle_avoidance_module/schema/static_obstacle_avoidance.schema.json

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Jul 29, 2024
autowarefoundation#7715)

* refactor(static_obstacle_avoidance): organize params for drivable lane

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* Update planning/behavior_path_planner/autoware_behavior_path_static_obstacle_avoidance_module/schema/static_obstacle_avoidance.schema.json

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants