Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pointcloud_preprocessor): add unit test for distortion corrector node #7801

Conversation

vividf
Copy link
Contributor

@vividf vividf commented Jul 3, 2024

Description

Unit test for distortion corrector node. Especially for the distortion_corrector.cpp

Tests performed

Build

colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Release --packages-select pointcloud_preprocessor

Test

colcon test --packages-select pointcloud_preprocessor --event-handlers console_cohesion+
  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: vividf <yihsiang.fang@tier4.jp>
@github-actions github-actions bot added the component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) label Jul 3, 2024
Copy link

github-actions bot commented Jul 3, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and worked with my local environment

@vividf vividf enabled auto-merge (squash) July 3, 2024 14:32
@vividf vividf self-assigned this Jul 3, 2024
@vividf vividf disabled auto-merge July 3, 2024 15:12
@vividf vividf added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 3, 2024
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

Attention: Patch coverage is 85.44061% with 38 lines in your changes missing coverage. Please review.

Project coverage is 28.72%. Comparing base (fbbc44c) to head (9f0f022).
Report is 1 commits behind head on main.

Files Patch % Lines
...eprocessor/test/test_distortion_corrector_node.cpp 85.44% 0 Missing and 38 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7801      +/-   ##
==========================================
+ Coverage   28.55%   28.72%   +0.16%     
==========================================
  Files        1586     1590       +4     
  Lines      115879   116167     +288     
  Branches    49384    49572     +188     
==========================================
+ Hits        33093    33372     +279     
+ Misses      73823    73797      -26     
- Partials     8963     8998      +35     
Flag Coverage Δ *Carryforward flag
differential 11.56% <85.44%> (?)
total 28.56% <ø> (+<0.01%) ⬆️ Carriedforward from fbbc44c

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vividf vividf merged commit c9aa86c into autowarefoundation:main Jul 3, 2024
37 of 39 checks passed
palas21 pushed a commit to palas21/autoware.universe that referenced this pull request Jul 12, 2024
… node (autowarefoundation#7801)

feat: add unit test for distoriton corrector node

Signed-off-by: vividf <yihsiang.fang@tier4.jp>
Signed-off-by: palas21 <palas21@itu.edu.tr>
tby-udel pushed a commit to tby-udel/autoware.universe that referenced this pull request Jul 14, 2024
… node (autowarefoundation#7801)

feat: add unit test for distoriton corrector node

Signed-off-by: vividf <yihsiang.fang@tier4.jp>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
… node (#7801)

feat: add unit test for distoriton corrector node

Signed-off-by: vividf <yihsiang.fang@tier4.jp>
Ariiees pushed a commit to Ariiees/autoware.universe that referenced this pull request Jul 22, 2024
… node (autowarefoundation#7801)

feat: add unit test for distoriton corrector node

Signed-off-by: vividf <yihsiang.fang@tier4.jp>
TomohitoAndo pushed a commit to tier4/autoware.universe that referenced this pull request Sep 10, 2024
… node (autowarefoundation#7801)

feat: add unit test for distoriton corrector node

Signed-off-by: vividf <yihsiang.fang@tier4.jp>
TetsuKawa pushed a commit to tier4/autoware.universe that referenced this pull request Jan 23, 2025
… node (autowarefoundation#7801)

feat: add unit test for distoriton corrector node

Signed-off-by: vividf <yihsiang.fang@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants