Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(radar)!: add package name prefix of autoware_ #7892

Merged

Conversation

technolojin
Copy link
Contributor

@technolojin technolojin commented Jul 8, 2024

Description

This PR adds the autoware_ prefix to the package name.

Changes are as following.

  1. Folder name (appears as file renaming)
  2. Package names in CMakeLists.txt, package.xml
  3. README.md
  4. Launch files $(find-pkg-share ...)
  5. .github/CODEOWNERS

This PR do not contains any logic change.

Related links

Part of: autowarefoundation/autoware#4569

How was this PR tested?

Tested in a local recompute environment and the TIER IV Cloud environment.

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Jul 8, 2024
Copy link

github-actions bot commented Jul 8, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@technolojin technolojin force-pushed the refactor/prefix-radar-packages branch from 534db99 to acd324a Compare July 8, 2024 07:47
@technolojin technolojin marked this pull request as ready for review July 9, 2024 00:38
@technolojin technolojin added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 9, 2024
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.23%. Comparing base (951d4cc) to head (0e467c9).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7892      +/-   ##
==========================================
- Coverage   28.76%   28.23%   -0.54%     
==========================================
  Files        1593     1615      +22     
  Lines      116841   117472     +631     
  Branches    50011    49819     -192     
==========================================
- Hits        33608    33164     -444     
- Misses      74169    75260    +1091     
+ Partials     9064     9048      -16     
Flag Coverage Δ *Carryforward flag
differential 2.49% <ø> (?)
total 28.48% <ø> (-0.28%) ⬇️ Carriedforward from 5c46e85

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@technolojin technolojin self-assigned this Jul 9, 2024
@technolojin technolojin marked this pull request as draft July 9, 2024 05:34
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
…object_tracker

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
…ar_object_clustering

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
…ware_radar_fusion_to_detected_object

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
…r_crossing_objects_noise_filter

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
…_splitter

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
@technolojin technolojin force-pushed the refactor/prefix-radar-packages branch from 39eebb3 to 5c46e85 Compare July 9, 2024 05:41
@technolojin technolojin marked this pull request as ready for review July 10, 2024 01:33
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have confirmed that there is no change in logic and that it is a mechanical process.

Copy link
Contributor

@scepter914 scepter914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
(Note: without checking acting, when it is integrated we need to check acting)

@technolojin technolojin merged commit defce44 into autowarefoundation:main Jul 10, 2024
28 of 30 checks passed
@technolojin technolojin deleted the refactor/prefix-radar-packages branch July 11, 2024 05:34
Ariiees pushed a commit to Ariiees/autoware.universe that referenced this pull request Jul 22, 2024
…ation#7892)

* refactor: rename radar_object_tracker

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: rename package from radar_object_tracker to autoware_radar_object_tracker

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: rename package from radar_object_clustering to autoware_radar_object_clustering

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: rename package from radar_fusion_to_detected_object to autoware_radar_fusion_to_detected_object

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: rename radar_crossing_objects_noise_filter to autoware_radar_crossing_objects_noise_filter

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: rename object_velocity_splitter to autoware_object_velocity_splitter

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: rename object_range_splitter to autoware_object_range_splitter

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: update readme

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

---------

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants