-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(static_obstacle_avoidance): avoid object behind unavoidance object if unavoidable is not on the path #8066
Merged
satoshi-ota
merged 1 commit into
autowarefoundation:main
from
tier4:fix/logic-for-unavoidable
Jul 18, 2024
Merged
fix(static_obstacle_avoidance): avoid object behind unavoidance object if unavoidable is not on the path #8066
satoshi-ota
merged 1 commit into
autowarefoundation:main
from
tier4:fix/logic-for-unavoidable
Jul 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t if unavoidable is not on the path Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
go-sakayori
approved these changes
Jul 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
yhisaki
pushed a commit
to yhisaki/autoware.universe
that referenced
this pull request
Jul 19, 2024
…t if unavoidable is not on the path (autowarefoundation#8066) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
Ariiees
pushed a commit
to Ariiees/autoware.universe
that referenced
this pull request
Jul 22, 2024
…t if unavoidable is not on the path (autowarefoundation#8066) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
chihungtzeng
pushed a commit
to chihungtzeng/autoware.universe
that referenced
this pull request
Jul 23, 2024
…t if unavoidable is not on the path (autowarefoundation#8066) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Signed-off-by: chtseng <chtseng@itri.org.tw>
satoshi-ota
added a commit
to tier4/autoware.universe
that referenced
this pull request
Jul 29, 2024
…t if unavoidable is not on the path (autowarefoundation#8066) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota
added a commit
to tier4/autoware.universe
that referenced
this pull request
Jul 31, 2024
…t if unavoidable is not on the path (autowarefoundation#8066) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
esteve
pushed a commit
to esteve/autoware.universe
that referenced
this pull request
Aug 13, 2024
…t if unavoidable is not on the path (autowarefoundation#8066) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now if front object is NOT avoidable as following fig, this module doesn't generate avoidance path even when behind object is avoidable. I think if the front object blocks ego path, it's proper behavior. But if the ego can go through, this module must generate avoidance path for behind object.
After this PR, this module will output avoidance path for behind object if front object is NOT on the path.
If front object is on ego path, this module won't generate avoidance path.
Additionally, if the front object is RIGHT and behind object is LEFT, this module won't generate avoidance path because the avoidance path for behind object might conflict front object, and vice versa.
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.