Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(static_obstacle_avoidance): avoid object behind unavoidance object if unavoidable is not on the path #8066

Merged

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Jul 16, 2024

Description

Now if front object is NOT avoidable as following fig, this module doesn't generate avoidance path even when behind object is avoidable. I think if the front object blocks ego path, it's proper behavior. But if the ego can go through, this module must generate avoidance path for behind object.

image

After this PR, this module will output avoidance path for behind object if front object is NOT on the path.

Screenshot from 2024-07-17 17-01-30

If front object is on ego path, this module won't generate avoidance path.

image

Additionally, if the front object is RIGHT and behind object is LEFT, this module won't generate avoidance path because the avoidance path for behind object might conflict front object, and vice versa.

image

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

…t if unavoidable is not on the path

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jul 17, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link
Contributor

@go-sakayori go-sakayori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satoshi-ota satoshi-ota added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 18, 2024
@satoshi-ota satoshi-ota enabled auto-merge (squash) July 18, 2024 06:36
@satoshi-ota satoshi-ota merged commit 9256892 into autowarefoundation:main Jul 18, 2024
40 of 42 checks passed
@satoshi-ota satoshi-ota deleted the fix/logic-for-unavoidable branch July 18, 2024 06:49
yhisaki pushed a commit to yhisaki/autoware.universe that referenced this pull request Jul 19, 2024
…t if unavoidable is not on the path (autowarefoundation#8066)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
Ariiees pushed a commit to Ariiees/autoware.universe that referenced this pull request Jul 22, 2024
…t if unavoidable is not on the path (autowarefoundation#8066)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
chihungtzeng pushed a commit to chihungtzeng/autoware.universe that referenced this pull request Jul 23, 2024
…t if unavoidable is not on the path (autowarefoundation#8066)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: chtseng <chtseng@itri.org.tw>
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Jul 29, 2024
…t if unavoidable is not on the path (autowarefoundation#8066)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Jul 31, 2024
…t if unavoidable is not on the path (autowarefoundation#8066)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
esteve pushed a commit to esteve/autoware.universe that referenced this pull request Aug 13, 2024
…t if unavoidable is not on the path (autowarefoundation#8066)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants