-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(lane_change): skip path computation if len exceed dist to terminal start #8359
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
e82dcc9
to
29f8a24
Compare
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
29f8a24
to
e1fb69c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8359 +/- ##
==========================================
- Coverage 23.77% 23.77% -0.01%
==========================================
Files 1379 1381 +2
Lines 101359 101392 +33
Branches 38527 38529 +2
==========================================
+ Hits 24100 24101 +1
- Misses 74780 74811 +31
- Partials 2479 2480 +1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
9f7a103
into
autowarefoundation:main
…l start (autowarefoundation#8359) Skip computation if prepare length exceed distance to terminal start Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
…l start (autowarefoundation#8359) Skip computation if prepare length exceed distance to terminal start Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
…l start (autowarefoundation#8359) Skip computation if prepare length exceed distance to terminal start Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
…l start (autowarefoundation#8359) Skip computation if prepare length exceed distance to terminal start Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Signed-off-by: xtk8532704 <1041084556@qq.com>
Description
Lane change module evaluates the distance from preparation start to lane changing end at later phase.
Hence, if prepare path's lengths exceed distance to lane change terminal start, there will be unnecessary checks and computation before the evaluation.
This PR aims to fix this by skipping path computation if the prepare segment length exceed ego current distance to terminal start.
This PR also add
computation.hpp/cpp
to avoidutils.hpp/cpp
file from having too many number of linesAfter PR
Path exceed ego dist to terminal start is being rejected.
Related links
Depends on #8358
Parent Issue:
How was this PR tested?
PSIM
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.