fix(goal_planner): fix lane departure check not working correctly due to uninitialized variable #8449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kosuke55
requested review from
danielsanchezaran,
kyoichi-sugahara,
soblin,
satoshi-ota,
shmpwk,
TomohitoAndo and
tkimura4
as code owners
github-actions
bot
added
type:documentation
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
kosuke55
force-pushed
the
fix/shift_lane_departure_check
branch
from
339cfb4 to
70710b3
Compare
kosuke55
added
the
run:build-and-test-differential
4 tasks
kosuke55
force-pushed
the
fix/shift_lane_departure_check
branch
from
70710b3 to
dc8b47b
Compare
kyoichi-sugahara
approved these changes
Aug 13, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8449 +/- ##
==========================================
- Coverage 23.85% 23.83% -0.02%
==========================================
Files 1379 1383 +4
Lines 101656 101658 +2
Branches 38669 38630 -39
==========================================
- Hits 24252 24234 -18
- Misses 74913 74966 +53
+ Partials 2491 2458 -33
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
… to uninitialized variable Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55
force-pushed
the
fix/shift_lane_departure_check
branch
from
dc8b47b to
5ebdc8c
Compare
kosuke55
added a commit
to tier4/autoware.universe
that referenced
this pull request
Aug 15, 2024
… to uninitialized variable (autowarefoundation#8449) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
xtk8532704
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Aug 15, 2024
… to uninitialized variable (autowarefoundation#8449) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: xtk8532704 <1041084556@qq.com>
TetsuKawa
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Jan 23, 2025
… to uninitialized variable (autowarefoundation#8449) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With #7193,
createVehicleFootprintsmust now have aparam_.footprint_extra_marginargument. The change only applies to start planner, not goal planner. This PR adds that parameter to the goal planner as well.This uninitialized variable could cause
footprint_extra_marginto benanin some environments and lane departure checker to be incorrect As a result, all paths were judged as out of lane, and there was a bug that no candidate path was generated.before
after
Related links
launcher:
Parent Issue:
Private Links:
How was this PR tested?
2024/08/13 https://evaluation.tier4.jp/evaluation/reports/ce28c429-dedc-5b18-b103-74a0e3e2e57a/?project_id=prd_jt
3988/3990
https://evaluation.tier4.jp/evaluation/reports/tables/new?catalog_id=095ae8b3-a23b-4a08-8674-10a681449693&filter=&job_id=9d134b89-17f3-530c-bdee-31558fc970a5&project_id=prd_jt&table_config=date%2Ctotal%2Chide&target_ids=97f129f8-1237-53e4-bb37-4897e6fde01d
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.