Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(static_obstacle_avoidance): use wrong parameter #8720

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Sep 3, 2024

Description

There is a bug to use wrong parameter. It should use min_prepare_time instead of min_prepare_distance.

Related links

Parent Issue:

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Sep 3, 2024
Copy link

github-actions bot commented Sep 3, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@satoshi-ota satoshi-ota added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 3, 2024
@satoshi-ota satoshi-ota enabled auto-merge (squash) September 3, 2024 02:08
@satoshi-ota satoshi-ota merged commit 01bde15 into autowarefoundation:main Sep 3, 2024
39 checks passed
@satoshi-ota satoshi-ota deleted the fix/use-wrong-parameter branch September 3, 2024 02:21
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 24.15%. Comparing base (58297a0) to head (6c420e2).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...r_path_static_obstacle_avoidance_module/helper.hpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8720      +/-   ##
==========================================
- Coverage   24.15%   24.15%   -0.01%     
==========================================
  Files        1401     1401              
  Lines      102286   102300      +14     
  Branches    38818    38818              
==========================================
- Hits        24711    24706       -5     
- Misses      75097    75114      +17     
- Partials     2478     2480       +2     
Flag Coverage Δ *Carryforward flag
differential 20.05% <0.00%> (?)
total 24.15% <ø> (-0.01%) ⬇️ Carriedforward from 58297a0

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Sep 3, 2024
…on#8720)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Sep 3, 2024
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Sep 3, 2024
…on#8720)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
saka1-s pushed a commit to tier4/autoware.universe that referenced this pull request Sep 3, 2024
…on#8720) (#1502)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
ktro2828 pushed a commit to ktro2828/autoware.universe that referenced this pull request Sep 18, 2024
…on#8720)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
TetsuKawa pushed a commit to tier4/autoware.universe that referenced this pull request Jan 23, 2025
…on#8720)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
TetsuKawa pushed a commit to tier4/autoware.universe that referenced this pull request Jan 23, 2025
…on#8720) (#1502)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants