-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(autoware_map_based_prediction): replace pow #8751
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
41099ee
to
0331b26
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8751 +/- ##
==========================================
- Coverage 25.04% 25.03% -0.02%
==========================================
Files 1315 1317 +2
Lines 97969 98009 +40
Branches 37804 37806 +2
==========================================
Hits 24536 24536
- Misses 70923 70963 +40
Partials 2510 2510
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…8751) Signed-off-by: emuemuJP <k.matsumoto.0807@gmail.com>
Description
A performance analysis of the
map_based_prediction
with VTune was performed. The generated frame graph is below.For example, you see
std::pow
accounts for 50% of thegenerateFrenetPath
function's processing time.Replacing
std::pow
with a simple multiplier reduces the computation time of this function from2.2
ms to0.6
ms for 1000 calculations. This is the PR.(The function is called for each combination of "the number of objects" and "the number of predicted paths".)
Related links
None
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.