fix(goal_planner): fix time_keeper race #8780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
soblin
requested review from
danielsanchezaran,
kosuke55,
kyoichi-sugahara,
satoshi-ota,
shmpwk,
TomohitoAndo and
tkimura4
as code owners
github-actions
bot
added
the
component:planning
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
kosuke55
approved these changes
Sep 5, 2024
kosuke55
added
the
run:build-and-test-differential
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8780 +/- ##
==========================================
- Coverage 25.01% 24.94% -0.07%
==========================================
Files 1322 1326 +4
Lines 98044 98104 +60
Branches 37820 37790 -30
==========================================
- Hits 24521 24473 -48
- Misses 71044 71152 +108
Partials 2479 2479
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kosuke55
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 6, 2024
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
emuemuJP
pushed a commit
to arayabrain/autoware.universe.origin
that referenced
this pull request
Sep 10, 2024
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> Signed-off-by: emuemuJP <k.matsumoto.0807@gmail.com>
shmpwk
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 25, 2024
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix data race to time_keeper
onTimer::need_update::hasDecidedPath::checkDecidingPathStatus::isSafePath maybe called both from main thread and background thread
Related links
Parent Issue:
How was this PR tested?
just removing debug info
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.