fix(mission_planner): return without change_route if new route is empty #9101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kosuke55
requested review from
isamu-takagi,
soblin,
mitsudome-r,
TakaHoribe and
takayuki5168
as code owners
github-actions
bot
added
the
component:planning
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
kosuke55
added
the
run:build-and-test-differential
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9101 +/- ##
==========================================
- Coverage 27.55% 27.53% -0.02%
==========================================
Files 1304 1311 +7
Lines 101047 101113 +66
Branches 39236 39239 +3
==========================================
Hits 27843 27843
- Misses 70580 70646 +66
Partials 2624 2624
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
isamu-takagi
approved these changes
Oct 17, 2024
kosuke55
changed the title
kosuke55
force-pushed
the
fix/mission_planner_empty
branch
2 times, most recently
from
7b6f8d0 to
c56de80
Compare
kosuke55
requested review from
rej55,
go-sakayori,
kyoichi-sugahara,
satoshi-ota,
shmpwk,
TomohitoAndo,
tkimura4 and
zulfaqar-azmi-t4
as code owners
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55
force-pushed
the
fix/mission_planner_empty
branch
from
c56de80 to
5972be5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Looks like an implementation error.
If we do not return, an emtpy route may be set.
Related links
Parent Issue:
How was this PR tested?
2024/10/21 https://evaluation.tier4.jp/evaluation/reports/d8006304-00be-5558-9c86-1576794020f1/?project_id=prd_jt
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.