Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(crosswalk): fix occlusion detection range calculation and add debug markers #9121

Merged

Conversation

maxime-clem
Copy link
Contributor

Description

Fix a mistake in the detection range calculation.

  • Before: detection range (m) = time for ego to reach the crosswalk (s) divided by occluded object velocity (m/s).
    • seconds divided by meters per seconds --> second squared per meter ⚠️
  • After: detection range (m) = time for ego to reach the crosswalk (s) multiplied by occluded object velocity (m/s).
    • seconds multiplied by meters per seconds --> meters. ✔️

Also do a small refactoring and add some markers to visualize the occlusion detection area

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Oct 21, 2024
Copy link

github-actions bot commented Oct 21, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
This reverts commit 4b379b6.

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem maxime-clem force-pushed the fix/crosswalk-occlusions branch from 1bf4d5d to e53ba7e Compare October 21, 2024 05:16
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem maxime-clem added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 21, 2024
@maxime-clem maxime-clem marked this pull request as ready for review October 21, 2024 05:34
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 27 lines in your changes missing coverage. Please review.

Project coverage is 28.24%. Comparing base (20ebe9d) to head (1903f6b).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
..._velocity_crosswalk_module/src/scene_crosswalk.cpp 0.00% 24 Missing ⚠️
...locity_crosswalk_module/src/occluded_crosswalk.cpp 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9121      +/-   ##
==========================================
- Coverage   28.25%   28.24%   -0.02%     
==========================================
  Files        1304     1309       +5     
  Lines      101062   101116      +54     
  Branches    39236    39241       +5     
==========================================
+ Hits        28556    28557       +1     
- Misses      69686    69738      +52     
- Partials     2820     2821       +1     
Flag Coverage Δ *Carryforward flag
differential 17.54% <0.00%> (?)
total 28.26% <ø> (+<0.01%) ⬆️ Carriedforward from 20ebe9d

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@yuki-takagi-66 yuki-takagi-66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxime-clem maxime-clem merged commit add03e2 into autowarefoundation:main Oct 21, 2024
40 of 42 checks passed
@maxime-clem maxime-clem deleted the fix/crosswalk-occlusions branch October 21, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants