-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(crosswalk): fix occlusion detection range calculation and add debug markers #9121
fix(crosswalk): fix occlusion detection range calculation and add debug markers #9121
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
This reverts commit 4b379b6. Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
1bf4d5d
to
e53ba7e
Compare
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9121 +/- ##
==========================================
- Coverage 28.25% 28.24% -0.02%
==========================================
Files 1304 1309 +5
Lines 101062 101116 +54
Branches 39236 39241 +5
==========================================
+ Hits 28556 28557 +1
- Misses 69686 69738 +52
- Partials 2820 2821 +1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Fix a mistake in the detection range calculation.
m
) = time for ego to reach the crosswalk (s
) divided by occluded object velocity (m/s
).m
) = time for ego to reach the crosswalk (s
) multiplied by occluded object velocity (m/s
).Also do a small refactoring and add some markers to visualize the occlusion detection area
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.