Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_ekf_localizer): publish processing_time_ms #9443

Conversation

SakodaShintaro
Copy link
Contributor

Description

There is a tool for visualizing processing_time_ms in autoware_tools.

However, autoware_ekf_localizer currently does not publish the required topic. To use the above tools, a node needs to publish a topic with the type tier4_debug_msgs::msg::Float64Stamped and the name processing_time_ms.

Therefore, this pull request adds a processing_time_ms publisher to autoware_ekf_localizer.

How was this PR tested?

system_performance_plotter

ros2 bag record -o /path/to/result_rosbag --use-sim-time -a

and

ros2 run autoware_debug_tools processing_time_plotter \
    -c localization -s --skip_plt_show \
    /path/to/result_rosbag 

The result directory is generated at current directory.

localization_processing_time-24-11-25-14-26-03

Notes for reviewers

None.

Interface changes

Topic changes

Additions and removals

Change type Topic Type Topic Name Message Type Description
Added Pub ~/debug/processing_time_ms tier4_debug_msgs::msg::Float64Stamped The processing time

Effects on system behavior

None.

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
@SakodaShintaro SakodaShintaro added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 25, 2024
@SakodaShintaro SakodaShintaro self-assigned this Nov 25, 2024
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) labels Nov 25, 2024
Copy link

github-actions bot commented Nov 25, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.90%. Comparing base (19364ff) to head (098f205).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9443      +/-   ##
==========================================
- Coverage   29.27%   28.90%   -0.38%     
==========================================
  Files        1441     1438       -3     
  Lines      108617   108109     -508     
  Branches    41582    41377     -205     
==========================================
- Hits        31794    31245     -549     
- Misses      73740    73838      +98     
+ Partials     3083     3026      -57     
Flag Coverage Δ *Carryforward flag
differential 25.93% <100.00%> (?)
total 28.89% <ø> (-0.38%) ⬇️ Carriedforward from 51f9380

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SakodaShintaro SakodaShintaro merged commit 824a7d5 into autowarefoundation:main Nov 26, 2024
32 checks passed
@SakodaShintaro SakodaShintaro deleted the fix/publish_processing_time_ms branch November 26, 2024 07:23
NorahXiong pushed a commit to NorahXiong/autoware.universe that referenced this pull request Jan 24, 2025
…efoundation#174)

* refactor(ekf_localizer)!: prefix package and namespace with autoware (autowarefoundation#8888)

* import lanelet2_map_preprocessor

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* move headers to include/autoware/efk_localier

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

---------

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* refactor(localization_util)!: prefix package and namespace with autoware (autowarefoundation#8922)

add autoware prefix to localization_util

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* fix(autoware_ekf_localizer): remove `timer_tf_` (autowarefoundation#9244)

Removed timer_tf_

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* chore(package.xml): bump version to 0.38.0 (autowarefoundation#9266) (autowarefoundation#9284)

* unify package.xml version to 0.37.0



* remove system_monitor/CHANGELOG.rst



* add changelog



* 0.38.0

---------

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* fix: fix ticket links to point to https://github.com/autowarefoundation/autoware.universe (autowarefoundation#9304)

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>

* fix(autoware_ekf_localizer): publish `processing_time_ms` (autowarefoundation#9443)

Fixed to publish processing_time_ms

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* fix(cpplint): include what you use - localization (autowarefoundation#9567)

Signed-off-by: M. Fatih Cırıt <mfc@autoware.org>

* chore(package.xml): bump version to 0.39.0 (autowarefoundation#9587)

* chore(package.xml): bump version to 0.39.0

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* fix: fix ticket links in CHANGELOG.rst

Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>

* fix: remove unnecessary diff

Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>

---------

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
Co-authored-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* chore(package.xml): bump version to 0.40.0 (autowarefoundation#9618)

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

* feat(ekf_localizer): check whether the initialpose has been set (autowarefoundation#9787)

* check set intialpose

Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>

* update png

Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* feat: tier4_debug_msgs changed to autoware_internal_debug_msgs in fies localization/autoware_ekf_localizer (autowarefoundation#9860)

Signed-off-by: vish0012 <vishalchhn42@gmail.com>
Co-authored-by: SakodaShintaro <shintaro.sakoda@tier4.jp>

* feat: add autoware_internal_msgs repo's link to build_depends.repos file

Signed-off-by: Motsu-san <masahiro.sakamoto@tier4.jp>

* chore: delete the needless file CHANGELOG.rst

Signed-off-by: Motsu-san <masahiro.sakamoto@tier4.jp>

* chore: initialize autoware_ekf_localizer versioning on autoware.core

Signed-off-by: Motsu-san <masahiro.sakamoto@tier4.jp>

---------

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Signed-off-by: M. Fatih Cırıt <mfc@autoware.org>
Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>
Signed-off-by: vish0012 <vishalchhn42@gmail.com>
Signed-off-by: Motsu-san <masahiro.sakamoto@tier4.jp>
Co-authored-by: Masaki Baba <maumaumaumaumaumaumaumaumaumau@gmail.com>
Co-authored-by: SakodaShintaro <shintaro.sakoda@tier4.jp>
Co-authored-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Co-authored-by: Esteve Fernandez <33620+esteve@users.noreply.github.com>
Co-authored-by: M. Fatih Cırıt <xmfcx@users.noreply.github.com>
Co-authored-by: Ryohsuke Mitsudome <43976834+mitsudome-r@users.noreply.github.com>
Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
Co-authored-by: Yamato Ando <yamato.ando@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Vishal Chauhan <40782713+vish0012@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants