fix(autoware_lidar_transfusion): fixed rounding errors that caused illegal memory access #9796
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In centerpoint #9795
we encountered rounding errors resulting from floating precision arithmetic in which points nearing the pointcloud ranges would generate invalid voxel ids. Since it is not a heavy operation, we decided to clip the values which makes it a little more resilient.
Transfusion uses a different way of generating voxel ids, which makes the problem a bug, but not one that causes cuda errors, so it probably was silent until now 😱
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.