Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: view LaneId on PathWithLaneIdFootprint plugin #984

Merged
merged 4 commits into from
May 30, 2022

Conversation

h-ohta
Copy link
Contributor

@h-ohta h-ohta commented May 27, 2022

Description

  • view lane id for each path points
    image

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@h-ohta h-ohta requested review from TakaHoribe and takayuki5168 May 27, 2022 11:52
@h-ohta h-ohta requested a review from tkimura4 May 27, 2022 11:53
@codecov
Copy link

codecov bot commented May 27, 2022

Codecov Report

Merging #984 (67dc34b) into main (2584cbd) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main    #984      +/-   ##
========================================
- Coverage   9.55%   9.53%   -0.02%     
========================================
  Files        941     941              
  Lines      58313   58420     +107     
  Branches   10577   10577              
========================================
  Hits        5570    5570              
- Misses     48026   48133     +107     
  Partials    4717    4717              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 9.55% <0.00%> (ø) Carriedforward from 2b2cd9c

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...in/include/path_with_lane_id_footprint/display.hpp 0.00% <0.00%> (ø)
...plugin/src/path_with_lane_id_footprint/display.cpp 0.00% <0.00%> (ø)
...on/tier4_planning_rviz_plugin/src/path/display.cpp 0.00% <0.00%> (ø)
...r4_planning_rviz_plugin/src/tools/max_velocity.cpp 0.00% <0.00%> (ø)
...r4_planning_rviz_plugin/src/trajectory/display.cpp 0.00% <0.00%> (ø)
...planning_rviz_plugin/src/drivable_area/display.cpp 0.00% <0.00%> (ø)
...lanning_rviz_plugin/src/path_footprint/display.cpp 0.00% <0.00%> (ø)
...anning_rviz_plugin/src/tools/jsk_overlay_utils.cpp 0.00% <0.00%> (ø)
...ning_rviz_plugin/src/path_with_lane_id/display.cpp 0.00% <0.00%> (ø)
...g_rviz_plugin/src/trajectory_footprint/display.cpp 0.00% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2584cbd...67dc34b. Read the comment docs.

Copy link
Contributor

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
image

@tkimura4
Copy link
Contributor

pre-commit.ci failed. Could you fix it?

common/tier4_planning_rviz_plugin/include/path_with_lane_id_footprint/display.hpp:86:  Add #include <utility> for pair<>  [build/include_what_you_use] [4]
Done processing common/tier4_planning_rviz_plugin/include/path_with_lane_id_footprint/display.hpp

h-ohta and others added 2 commits May 27, 2022 21:09
Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
@h-ohta
Copy link
Contributor Author

h-ohta commented May 30, 2022

CI is good, so I'll merge it.

@h-ohta h-ohta merged commit 180dba1 into autowarefoundation:main May 30, 2022
@h-ohta h-ohta deleted the feat/view_lane_ids branch May 30, 2022 01:11
soblin pushed a commit to soblin/autoware.universe that referenced this pull request Jun 5, 2022
…on#984)

* feat: view LaneId on PathWithLaneIdFootprint plugin

* ci(pre-commit): autofix

* fix: add utility

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
ktro2828 pushed a commit to ktro2828/autoware.universe that referenced this pull request Jun 7, 2022
…on#984)

* feat: view LaneId on PathWithLaneIdFootprint plugin

* ci(pre-commit): autofix

* fix: add utility

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
* feat: view LaneId on PathWithLaneIdFootprint plugin

* ci(pre-commit): autofix

* fix: add utility

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
* feat: view LaneId on PathWithLaneIdFootprint plugin

* ci(pre-commit): autofix

* fix: add utility

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
* feat: view LaneId on PathWithLaneIdFootprint plugin

* ci(pre-commit): autofix

* fix: add utility

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
* feat: view LaneId on PathWithLaneIdFootprint plugin

* ci(pre-commit): autofix

* fix: add utility

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
saka1-s pushed a commit to saka1-s/autoware.universe that referenced this pull request Nov 28, 2023
…ance_0.11

fix(lane_change): fix terminal stop distance (autowarefoundation#5392)
iwatake2222 pushed a commit to iwatake2222/autoware.universe that referenced this pull request Jan 17, 2025
…refoundation#984)

remove ndt node alive monitoring

Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants