Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_test_utils): add visualization and yaml dumper for PathWithLaneId #9841

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Jan 7, 2025

Description

reopen this PR #9784 due to CI error

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

soblin and others added 7 commits December 25, 2024 16:34
…WithLaneId

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Jan 7, 2025
Copy link

github-actions bot commented Jan 7, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@soblin soblin added run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed component:common Common packages from the autoware-common repository. (auto-assigned) labels Jan 7, 2025
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@soblin soblin enabled auto-merge (squash) January 7, 2025 06:36
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 35 lines in your changes missing coverage. Please review.

Project coverage is 29.60%. Comparing base (ab845fb) to head (5da7af6).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...ommon/autoware_test_utils/src/mock_data_parser.cpp 0.00% 31 Missing ⚠️
...n/autoware_test_utils/src/topic_snapshot_saver.cpp 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9841      +/-   ##
==========================================
+ Coverage   29.59%   29.60%   +0.01%     
==========================================
  Files        1451     1455       +4     
  Lines      108919   108984      +65     
  Branches    42597    42615      +18     
==========================================
+ Hits        32232    32267      +35     
- Misses      73589    73617      +28     
- Partials     3098     3100       +2     
Flag Coverage Δ *Carryforward flag
differential 32.12% <0.00%> (?)
total 29.61% <ø> (+0.01%) ⬆️ Carriedforward from 0bd99b9

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soblin soblin merged commit 9d5c246 into autowarefoundation:main Jan 7, 2025
67 of 69 checks passed
@soblin soblin deleted the feat/autoware_test_utils/add-visualization-for-path branch January 7, 2025 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants