fix(autoware_motion_velocity_obstacle_velocity_limiter_module): remove cppcheck suppressions #9843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e cppcheck suppressions Signed-off-by: veqcc <ryuta.kambe@tier4.jp>
github-actions
bot
added
the
component:planning
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
veqcc
added
the
run:build-and-test-differential
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9843 +/- ##
==========================================
- Coverage 29.62% 29.61% -0.01%
==========================================
Files 1452 1456 +4
Lines 108921 108945 +24
Branches 42577 42571 -6
==========================================
+ Hits 32265 32267 +2
- Misses 73421 73445 +24
+ Partials 3235 3233 -2
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
maxime-clem
approved these changes
Jan 7, 2025
veqcc
deleted the
fix/autoware_motion_velocity_obstacle_velocity_limiter_module
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The last
cppcheck-weeklyCI detected something wrong inautoware_motion_velocity_obstacle_velocity_limiter_module.https://github.com/autowarefoundation/autoware.universe/actions/runs/12624163932
I decided to ignore
benchmarksdirectories instead of fixing the warnings.Thus, I removed cppcheck-related suppressions from
autoware_motion_velocity_obstacle_velocity_limiter_module/benchmarks/Related links
benchmarksdirectories will be ignored by cppcheck with the following PR#9842
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.