refactor(goal_planner): remove duplicated execution condition
CodeScene PR Check
✅ Code Health Quality Gates: OK
- Declining Code Health: 0 findings(s) 🚩
- Improving Code Health: 3 findings(s) ✅
- Affected Hotspots: 1 files(s) 🔥
Recommended Review Level: Detailed -- Increased risk for defects: No code is modified, but the change set deletes (7) lines of code, which is an unusal pattern in this repo.
View detailed results in CodeScene
Details
✅ Improving Code Health:
- Lines of Code in a Single File goal_planner_module.cpp 🔥
- Overall Code Complexity goal_planner_module.cpp 🔥
- Complex Method goal_planner_module.cpp: GoalPlannerModule::isExecutionRequested 🔥
Annotations
Check notice on line 1 in planning/behavior_path_goal_planner_module/src/goal_planner_module.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Lines of Code in a Single File
The lines of code decreases from 1480 to 1477, improve code health by reducing it to 1000. The number of Lines of Code in a single file. More Lines of Code lowers the code health.
Check notice on line 401 in planning/behavior_path_goal_planner_module/src/goal_planner_module.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Complex Method
GoalPlannerModule::isExecutionRequested decreases in cyclomatic complexity from 14 to 13, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check notice on line 1 in planning/behavior_path_goal_planner_module/src/goal_planner_module.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Overall Code Complexity
The mean cyclomatic complexity decreases from 4.78 to 4.76, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.