Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Remove importing darknet in Autoware Docker #1548

Closed
wants to merge 1 commit into from
Closed

[Fix] Remove importing darknet in Autoware Docker #1548

wants to merge 1 commit into from

Conversation

kfunaoka
Copy link

@kfunaoka kfunaoka commented Oct 2, 2018

Status

DEVELOPMENT

Description

Yolo2/3 implementations were integrated into yolo_darknet_detect.
yolo_darknet_detect is self contained and doesn't require pjreddie/darknet.
Importing darknet outside Autoware repository in Docker is no longer necessary.

Related PRs

List related PRs against other branches:

branch PR
feature/std_perception_msg #1419

Steps to Test or Reproduce

cd Autoware/docker/generic
./build.sh kinetic

@kfunaoka kfunaoka requested a review from amc-nu October 2, 2018 01:34
@kfunaoka kfunaoka changed the title [Fix] Remove darknet from Autoware Docker [Fix] Remove importing darknet from Autoware Docker Oct 2, 2018
@kfunaoka kfunaoka changed the title [Fix] Remove importing darknet from Autoware Docker [Fix] Remove importing darknet in Autoware Docker Oct 2, 2018
@gbiggs
Copy link

gbiggs commented Mar 15, 2019

@kfunaoka Is this PR still valid? It looks like it might have been superseded by the recent Docker files cleanup.

@gbiggs gbiggs added type:bug Software flaws or errors. in review labels Mar 15, 2019
@amc-nu
Copy link
Member

amc-nu commented Mar 18, 2019

Replaced by #1946

@amc-nu amc-nu closed this Mar 18, 2019
@kfunaoka kfunaoka deleted the feature/remove_darknet_from_docker branch April 12, 2019 05:05
@mitsudome-r mitsudome-r added the version:autoware-ai Autoware.AI label Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Software flaws or errors. version:autoware-ai Autoware.AI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants