Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/remove catkin #2042

Merged
merged 1 commit into from
Feb 28, 2019
Merged

Feature/remove catkin #2042

merged 1 commit into from
Feb 28, 2019

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Feb 27, 2019

Status

PRODUCTION / DEVELOPMENT

Description

Removed the catkin scripts now that all packages have install() commands (thanks @amc-nu !)

@esteve esteve changed the base branch from master to develop February 27, 2019 12:36
sgermanserrano
sgermanserrano approved these changes Feb 27, 2019
View reviewed changes
Copy link

@sgermanserrano sgermanserrano left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. @esteve this PR will break the Dockerfiles if #1946 is not merged also.

@gbiggs
Copy link

gbiggs commented Feb 28, 2019

Just want to check: We are able to build cross-releases once these scripts are gone, right? Someone has tested that?

@amc-nu
Copy link
Member

amc-nu commented Feb 28, 2019

@gbiggs afaik, these are already being used in CI
pipelines

@gbiggs
Copy link

gbiggs commented Feb 28, 2019

Should be good to go, then. Merge away!

@sgermanserrano sgermanserrano merged commit ef7bfa2 into autowarefoundation:develop Feb 28, 2019
@esteve
Copy link
Contributor Author

esteve commented Feb 28, 2019

@gbiggs we've been building with the colcon scripts since 1.9 IIRC

@esteve esteve deleted the feature/remove_catkin branch February 28, 2019 16:20
anubhavashok pushed a commit to NuronLabs/autoware.ai that referenced this pull request Sep 7, 2021
@esteve @sgermanserrano
Remove catkin_make_release* scripts (autowarefoundation#2042)
0c2e363
@mitsudome-r mitsudome-r added the version:autoware-ai Autoware.AI label Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgermanserrano sgermanserrano sgermanserrano approved these changes

@amc-nu amc-nu amc-nu approved these changes

@gbiggs gbiggs gbiggs approved these changes

Assignees
No one assigned
Labels
version:autoware-ai Autoware.AI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@esteve @gbiggs @amc-nu @sgermanserrano @mitsudome-r