Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add .fdignore file to allow fd in src #3247

Merged
merged 1 commit into from
Feb 4, 2023
Merged

chore: add .fdignore file to allow fd in src #3247

merged 1 commit into from
Feb 4, 2023

Conversation

xmfcx
Copy link
Contributor

@xmfcx xmfcx commented Feb 3, 2023

Signed-off-by: M. Fatih Cırıt mfc@leodrive.ai

Description

https://autowarefoundation.github.io/autoware-documentation/main/how-to-guides/applying-clang-tidy-to-ros-packages/#usage

I was trying to follow clang-tidy -p build/ $(fd -e cpp -e hpp --full-path "/autoware_utils/") command, I've realized because of the .gitignore file, /src/ was being ignored.

With this pr, fd command will work as expected with the added .fdignore file.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@xmfcx xmfcx requested a review from kenji-miyake February 3, 2023 15:45
@xmfcx xmfcx self-assigned this Feb 3, 2023
Copy link
Contributor

@kenji-miyake kenji-miyake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kenji-miyake kenji-miyake changed the title feat: add .fdignore file to allow fd in src chore: add .fdignore file to allow fd in src Feb 4, 2023
@kenji-miyake
Copy link
Contributor

@xmfcx Since it's not a feature, I changed the title to chore.

Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
@xmfcx xmfcx enabled auto-merge (squash) February 4, 2023 06:48
@xmfcx xmfcx merged commit 8e40b92 into main Feb 4, 2023
@xmfcx xmfcx deleted the add-fdignore branch February 4, 2023 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants