feat(setup): change option --no-dev to --runtime #3297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caiyuexiang
changed the title
kenji-miyake
reviewed
Mar 1, 2023
Signed-off-by: yuexiang.cai <sinan.cai@autocore.ai>
caiyuexiang
force-pushed
the
change-option-no-dev-to-runtime
branch
from
27fa4ae to
db6bb45
Compare
caiyuexiang
changed the title
|
@caiyuexiang Thank you! Could you please write some reasons for this change in the description section? It's for tracking in the future. |
Sure, information already added in description section. |
kenji-miyake
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: yuexiang.cai sinan.cai@autocore.ai
Description
Split from #2922.
The option --runtime will be used at the
set up runtime environmentphase in DockerFile, and the docker base image would be nvidia/cuda:x.x.x-runtime-ubuntuxx.xx. For ease of understanding, change the option name from --no-dev to --runtime.Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.