refactor: update ML model param files download #4533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badai-nguyen
force-pushed
the
refactor/ml_model_param_rework_model_download
branch
from
e35ddb0 to
fd509d2
Compare
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
badai-nguyen
force-pushed
the
refactor/ml_model_param_rework_model_download
branch
from
fd509d2 to
603acce
Compare
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
badai-nguyen
requested review from
esteve,
YoshiRi,
kminoda,
ktro2828 and
miursh
esteve
approved these changes
Apr 23, 2024
|
@badai-nguyen could you please update the https://github.com/badai-nguyen/autoware/tree/d9e1668ba5412dbb9402e83e80166d722493abb5/ansible/roles/artifacts#readme file to match this too? Right now it is not working for manual instruction followers. |
oguzkaganozt
pushed a commit
that referenced
this pull request
Apr 30, 2024
* fix: add yaml download Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: missing sha Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: sha5 Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * style(pre-commit): autofix --------- Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue: Separate the param.yaml file for ML model parameters and ML model handle node parameters autoware.universe#6590
PR: refactor(centerpoint, pointpainting): rearrange parameters for ML models and packages autoware.universe#6591
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.