Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docker): set image tag for qemu #5780

Merged
merged 2 commits into from
Feb 14, 2025
Merged

chore(docker): set image tag for qemu #5780

merged 2 commits into from
Feb 14, 2025

Conversation

amadeuszsz
Copy link
Contributor

@amadeuszsz amadeuszsz commented Feb 13, 2025 •
edited by xmfcx
Loading

Description

Potentially fixes docker image deployment for arm64.

Related PR:

How was this PR tested?

Notes for reviewers

None.

Effects on system behavior

None.

@amadeuszsz
chore(docker): set image tag for qemu
2d7927f 
Signed-off-by: Amadeusz Szymko <amadeusz.szymko.2@tier4.jp>
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 13, 2025 •
edited
Loading

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@amadeuszsz amadeuszsz mentioned this pull request Feb 13, 2025
Merged
@amadeuszsz
chore(docker): downgrade qemu version
57a8910 
Signed-off-by: Amadeusz Szymko <amadeusz.szymko.2@tier4.jp>
@xmfcx xmfcx added the tag:run-health-check Run health-check label Feb 14, 2025
@amadeuszsz
Copy link
Contributor Author

@xmfcx

Regarding this topic, people reporting different image tags which resolved their issue. I'm not sure which one is correct for our runner. If it is possible, I would like to ask you for manually trigger autoware-base workflow on this branch. If fail, we can check different tag reported by community. Current tag is the tag which was linked to latest few days ago...

@xmfcx
Copy link
Contributor

xmfcx commented Feb 14, 2025

@amadeuszsz duplicated this PR branch to this repo and testing here:

@xmfcx
Copy link
Contributor

xmfcx commented Feb 14, 2025

It has passed ✅

@youtalk -san, can we merge this?

@xmfcx xmfcx marked this pull request as ready for review February 14, 2025 05:03
youtalk
youtalk approved these changes Feb 14, 2025
View reviewed changes
Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the license. LGTM
https://github.com/tonistiigi/binfmt?tab=readme-ov-file#licenses

@youtalk youtalk merged commit 4374782 into autowarefoundation:main Feb 14, 2025
26 of 28 checks passed
@xmfcx
Copy link
Contributor

xmfcx commented Feb 14, 2025 •
edited
Loading

It's now being tested in main: https://github.com/autowarefoundation/autoware/actions/runs/13323241938 ✅

@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Feb 15, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youtalk youtalk youtalk approved these changes

@xmfcx xmfcx xmfcx approved these changes

@oguzkaganozt oguzkaganozt Awaiting requested review from oguzkaganozt oguzkaganozt is a code owner

Assignees

@amadeuszsz amadeuszsz

Labels
tag:run-health-check Run health-check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amadeuszsz @xmfcx @youtalk