Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tier4_perception_launch): add transfusion option for lidar_detection_model #1124

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

shmpwk
Copy link
Contributor

@shmpwk shmpwk commented Aug 20, 2024

Description

Add lidar_detection_model option in tier4_perception_launch according to autowarefoundation/autoware.universe#6890.
The default model: centerpoint won't change in this PR.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…tion_model

Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>
@shmpwk shmpwk requested a review from scepter914 August 20, 2024 02:39
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Aug 20, 2024
Copy link
Contributor

@scepter914 scepter914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shmpwk
Copy link
Contributor Author

shmpwk commented Aug 20, 2024

@kminoda
Could you give me your approval?

Copy link
Contributor

@kminoda kminoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, forgot to update this part.

@shmpwk shmpwk merged commit 5b01e24 into main Aug 20, 2024
14 checks passed
@shmpwk shmpwk deleted the feat/lidar_detection_model_opt branch August 20, 2024 06:03
shmpwk added a commit to tier4/autoware_launch that referenced this pull request Aug 20, 2024
…tion_model (autowarefoundation#1124)

Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>
shmpwk added a commit to tier4/autoware_launch that referenced this pull request Aug 20, 2024
…tion_model (autowarefoundation#1124) (#552)

Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>
kyoichi-sugahara pushed a commit to tier4/autoware_launch that referenced this pull request Aug 27, 2024
…tion_model (autowarefoundation#1124)

Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants