Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add option to select graph path depending on running mode #938

Conversation

TomohitoAndo
Copy link
Contributor

@TomohitoAndo TomohitoAndo commented Mar 28, 2024

Description

This PR adds option to select the graph path file depending on the mode (planning simulator, logging simulator, real vehicle) like system_error_monitor.

PR for universe

Tests performed

See autowarefoundation/autoware.universe#6700

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
@TomohitoAndo TomohitoAndo changed the title chore: add option of using graph path for simulation chore: add option to select graph path depending on running mode Mar 28, 2024
Copy link
Contributor

@ito-san ito-san left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomohitoAndo TomohitoAndo merged commit 7a65bc9 into autowarefoundation:main Mar 29, 2024
14 of 15 checks passed
@TomohitoAndo TomohitoAndo deleted the chore/diag-graph-add-sim-option branch March 29, 2024 08:15
4swinv pushed a commit to 4swinv/autoware_launch that referenced this pull request Apr 9, 2024
…owarefoundation#938)

chore: add option of using graph path for simulation

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request May 21, 2024
…owarefoundation#938)

chore: add option of using graph path for simulation

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request May 21, 2024
…handler

* feat: add option to launch mrm handler (autowarefoundation#929)

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* chore: add option to select graph path depending on running mode (autowarefoundation#938)

chore: add option of using graph path for simulation

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* feat: add a param file of a mrm handler node (autowarefoundation#927)

Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com>

* feat: update config to launch mrm_handler

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* feat(mrm_handler): enable comfortable stop

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

---------

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com>
Co-authored-by: Takagi, Isamu <43976882+isamu-takagi@users.noreply.github.com>
Co-authored-by: TetsuKawa <70682030+TetsuKawa@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants