Document symbol container name #1234
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is rather a proposal within demo than a pull request. It adds
containerNameinto the text which is shown in a document symbols list. It improves user experience as one can see where a symbol from. In the screenshots you can see that a couple structures can have the same function just implementing one trait. The similar experience is writing Python. A couple of class can have__init__method so in symbols you can't see which class the selected constructor for.I'm not sure about where to place
containerNamein a symbol list's item, so I'm open to suggestions. Currently I decided to add it as a prefix with::as a divisor. I didn't find a convinient way to make it as an option in settings.Take a look at the screenshots.