Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zombie burying ritual #1264

Open
wants to merge 4 commits into
base: next
Choose a base branch
from
Open

Zombie burying ritual #1264

wants to merge 4 commits into from

Commits on Oct 31, 2023

  1. Fix terminated LS processes turning into zombies [DRAFT]

    @ulidtko
    ulidtko committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    047ef00 View commit details
    Browse the repository at this point in the history

  2. Keep the RpcClient on deliberate server stop 

    Forgetting it here is premature, and will leak the server process.
Instead, let on_server_crash() handle the cleanup & deal with zombies.
    @ulidtko
    ulidtko committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    6d2223d View commit details
    Browse the repository at this point in the history

  3. Don't reinsert reaped RpcClient, no need (fixup)

    @ulidtko
    ulidtko committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    15a5934 View commit details
    Browse the repository at this point in the history

  4. Downgrade too chatty tracers to debug loglevel 

    The extra-verbose dumps of pages and pages of user-generated data *per message*
simply don't belong at INFO loglevel, killing it's usability.
    @ulidtko
    ulidtko committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    d7905a3 View commit details
    Browse the repository at this point in the history