Skip to content

Commit

Permalink
fix: changed disabled rules in datasets module (apache#10979)
Browse files Browse the repository at this point in the history
* Updated `put` method in `datasets/api.py`:
- changed return statements in put method
- removed disabled pylint rule too-many-return-statements
- removed disabled pylint rule arguments-differ since arguments match

* Removed disabled pylint rule arguments-differ in `delete()` method since arguments match
  • Loading branch information
kkucharc authored and auxten committed Nov 20, 2020
1 parent 071bd14 commit e11dcee
Showing 1 changed file with 8 additions and 9 deletions.
17 changes: 8 additions & 9 deletions superset/datasets/api.py
Original file line number Diff line number Diff line change
Expand Up @@ -216,9 +216,7 @@ def post(self) -> Response:
@protect()
@safe
@statsd_metrics
def put( # pylint: disable=too-many-return-statements, arguments-differ
self, pk: int
) -> Response:
def put(self, pk: int) -> Response:
"""Changes a Dataset
---
put:
Expand Down Expand Up @@ -270,24 +268,25 @@ def put( # pylint: disable=too-many-return-statements, arguments-differ
return self.response_400(message=error.messages)
try:
changed_model = UpdateDatasetCommand(g.user, pk, item).run()
return self.response(200, id=changed_model.id, result=item)
response = self.response(200, id=changed_model.id, result=item)
except DatasetNotFoundError:
return self.response_404()
response = self.response_404()
except DatasetForbiddenError:
return self.response_403()
response = self.response_403()
except DatasetInvalidError as ex:
return self.response_422(message=ex.normalized_messages())
response = self.response_422(message=ex.normalized_messages())
except DatasetUpdateFailedError as ex:
logger.error(
"Error updating model %s: %s", self.__class__.__name__, str(ex)
)
return self.response_422(message=str(ex))
response = self.response_422(message=str(ex))
return response

@expose("/<pk>", methods=["DELETE"])
@protect()
@safe
@statsd_metrics
def delete(self, pk: int) -> Response: # pylint: disable=arguments-differ
def delete(self, pk: int) -> Response:
"""Deletes a Dataset
---
delete:
Expand Down

0 comments on commit e11dcee

Please sign in to comment.