[vms/platformvm] Cleanup execution config tests (#3137)

ava-labs · Jun 24, 2024 · 1a9bc45 · 1a9bc45
1 parent 6eef08f
commit 1a9bc45
Showing 1 changed file with 27 additions and 90 deletions.
diff --git a/vms/platformvm/config/execution_config_test.go b/vms/platformvm/config/execution_config_test.go
@@ -4,6 +4,8 @@
 package config
 
 import (
+	"encoding/json"
+	"reflect"
 	"testing"
 	"time"
 
@@ -12,6 +14,23 @@ import (
 	"github.com/ava-labs/avalanchego/vms/platformvm/network"
 )
 
+// Requires all values in a struct to be initialized
+func verifyInitializedStruct(tb testing.TB, s interface{}) {
+	tb.Helper()
+
+	require := require.New(tb)
+
+	structType := reflect.TypeOf(s)
+	require.Equal(reflect.Struct, structType.Kind())
+
+	v := reflect.ValueOf(s)
+	for i := 0; i < v.NumField(); i++ {
+		field := v.Field(i)
+		require.True(field.IsValid(), "invalid field: ", structType.Field(i).Name)
+		require.False(field.IsZero(), "zero field: ", structType.Field(i).Name)
+	}
+}
+
 func TestExecutionConfigUnmarshal(t *testing.T) {
 	t.Run("default values from empty json", func(t *testing.T) {
 		require := require.New(t)
@@ -41,39 +60,7 @@ func TestExecutionConfigUnmarshal(t *testing.T) {
 
 	t.Run("all values extracted from json", func(t *testing.T) {
 		require := require.New(t)
-		b := []byte(`{
-			"network": {
-				"max-validator-set-staleness": 1,
-				"target-gossip-size": 2,
-				"push-gossip-percent-stake": 0.3,
-				"push-gossip-num-validators": 4,
-				"push-gossip-num-peers": 5,
-				"push-regossip-num-validators": 6,
-				"push-regossip-num-peers": 7,
-				"push-gossip-discarded-cache-size": 8,
-				"push-gossip-max-regossip-frequency": 9,
-				"push-gossip-frequency": 10,
-				"pull-gossip-poll-size": 11,
-				"pull-gossip-frequency": 12,
-				"pull-gossip-throttling-period": 13,
-				"pull-gossip-throttling-limit": 14,
-				"expected-bloom-filter-elements": 15,
-				"expected-bloom-filter-false-positive-probability": 16,
-				"max-bloom-filter-false-positive-probability": 17
-			},
-			"block-cache-size": 1,
-			"tx-cache-size": 2,
-			"transformed-subnet-tx-cache-size": 3,
-			"reward-utxos-cache-size": 5,
-			"chain-cache-size": 6,
-			"chain-db-cache-size": 7,
-			"block-id-cache-size": 8,
-			"fx-owner-cache-size": 9,
-			"checksums-enabled": true,
-			"mempool-prune-frequency": 60000000000
-		}`)
-		ec, err := GetExecutionConfig(b)
-		require.NoError(err)
+
 		expected := &ExecutionConfig{
 			Network: network.Config{
 				MaxValidatorSetStaleness:                    1,
@@ -105,64 +92,14 @@ func TestExecutionConfigUnmarshal(t *testing.T) {
 			ChecksumsEnabled:             true,
 			MempoolPruneFrequency:        time.Minute,
 		}
-		require.Equal(expected, ec)
-	})
+		verifyInitializedStruct(t, *expected)
+		verifyInitializedStruct(t, expected.Network)
 
-	t.Run("default values applied correctly", func(t *testing.T) {
-		require := require.New(t)
-		b := []byte(`{
-			"network": {
-				"max-validator-set-staleness": 1,
-				"target-gossip-size": 2,
-				"push-gossip-discarded-cache-size": 1024,
-				"push-gossip-max-regossip-frequency": 10000000000,
-				"pull-gossip-poll-size": 3,
-				"pull-gossip-frequency": 4,
-				"pull-gossip-throttling-period": 5
-			},
-			"block-cache-size": 1,
-			"tx-cache-size": 2,
-			"transformed-subnet-tx-cache-size": 3,
-			"reward-utxos-cache-size": 5,
-			"chain-cache-size": 6,
-			"chain-db-cache-size": 7,
-			"block-id-cache-size": 8,
-			"fx-owner-cache-size": 9,
-			"checksums-enabled": true
-		}`)
-		ec, err := GetExecutionConfig(b)
+		b, err := json.Marshal(expected)
 		require.NoError(err)
-		expected := &ExecutionConfig{
-			Network: network.Config{
-				MaxValidatorSetStaleness:                    1,
-				TargetGossipSize:                            2,
-				PushGossipPercentStake:                      DefaultExecutionConfig.Network.PushGossipPercentStake,
-				PushGossipNumValidators:                     DefaultExecutionConfig.Network.PushGossipNumValidators,
-				PushGossipNumPeers:                          DefaultExecutionConfig.Network.PushGossipNumPeers,
-				PushRegossipNumValidators:                   DefaultExecutionConfig.Network.PushRegossipNumValidators,
-				PushRegossipNumPeers:                        DefaultExecutionConfig.Network.PushRegossipNumPeers,
-				PushGossipDiscardedCacheSize:                1024,
-				PushGossipMaxRegossipFrequency:              10 * time.Second,
-				PushGossipFrequency:                         DefaultExecutionConfig.Network.PushGossipFrequency,
-				PullGossipPollSize:                          3,
-				PullGossipFrequency:                         4,
-				PullGossipThrottlingPeriod:                  5,
-				PullGossipThrottlingLimit:                   DefaultExecutionConfig.Network.PullGossipThrottlingLimit,
-				ExpectedBloomFilterElements:                 DefaultExecutionConfig.Network.ExpectedBloomFilterElements,
-				ExpectedBloomFilterFalsePositiveProbability: DefaultExecutionConfig.Network.ExpectedBloomFilterFalsePositiveProbability,
-				MaxBloomFilterFalsePositiveProbability:      DefaultExecutionConfig.Network.MaxBloomFilterFalsePositiveProbability,
-			},
-			BlockCacheSize:               1,
-			TxCacheSize:                  2,
-			TransformedSubnetTxCacheSize: 3,
-			RewardUTXOsCacheSize:         5,
-			ChainCacheSize:               6,
-			ChainDBCacheSize:             7,
-			BlockIDCacheSize:             8,
-			FxOwnerCacheSize:             9,
-			ChecksumsEnabled:             true,
-			MempoolPruneFrequency:        30 * time.Minute,
-		}
-		require.Equal(expected, ec)
+
+		actual, err := GetExecutionConfig(b)
+		require.NoError(err)
+		require.Equal(expected, actual)
 	})
 }