[antithesis] Remove assertions incompatible with fault injection (#3104)

Co-authored-by: Stephen Buttolph <stephen@avalabs.org>
ava-labs · Jun 14, 2024 · 7455c99 · 7455c99
1 parent e99d1ba
commit 7455c99
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 62 deletions.
diff --git a/tests/antithesis/avalanchego/main.go b/tests/antithesis/avalanchego/main.go
@@ -261,10 +261,6 @@ func (w *workload) issueXChainBaseTx(ctx context.Context) {
 	)
 	if err != nil {
 		log.Printf("failed to issue X-chain baseTx: %s", err)
-		assert.Unreachable("failed to issue X-chain baseTx", map[string]any{
-			"worker": w.id,
-			"err":    err,
-		})
 		return
 	}
 	log.Printf("issued new X-chain baseTx %s in %s", baseTx.ID(), time.Since(baseStartTime))
@@ -318,10 +314,6 @@ func (w *workload) issueXChainCreateAssetTx(ctx context.Context) {
 	)
 	if err != nil {
 		log.Printf("failed to issue X-chain create asset transaction: %s", err)
-		assert.Unreachable("failed to issue X-chain create asset transaction", map[string]any{
-			"worker": w.id,
-			"err":    err,
-		})
 		return
 	}
 	log.Printf("created new X-chain asset %s in %s", createAssetTx.ID(), time.Since(createAssetStartTime))
@@ -376,10 +368,6 @@ func (w *workload) issueXChainOperationTx(ctx context.Context) {
 	)
 	if err != nil {
 		log.Printf("failed to issue X-chain create asset transaction: %s", err)
-		assert.Unreachable("failed to issue X-chain create asset transaction", map[string]any{
-			"worker": w.id,
-			"err":    err,
-		})
 		return
 	}
 	log.Printf("created new X-chain asset %s in %s", createAssetTx.ID(), time.Since(createAssetStartTime))
@@ -391,10 +379,6 @@ func (w *workload) issueXChainOperationTx(ctx context.Context) {
 	)
 	if err != nil {
 		log.Printf("failed to issue X-chain operation transaction: %s", err)
-		assert.Unreachable("failed to issue X-chain operation transaction", map[string]any{
-			"worker": w.id,
-			"err":    err,
-		})
 		return
 	}
 	log.Printf("issued X-chain operation tx %s in %s", operationTx.ID(), time.Since(operationStartTime))
@@ -454,10 +438,6 @@ func (w *workload) issueXToPTransfer(ctx context.Context) {
 	)
 	if err != nil {
 		log.Printf("failed to issue X-chain export transaction: %s", err)
-		assert.Unreachable("failed to issue X-chain export transaction", map[string]any{
-			"worker": w.id,
-			"err":    err,
-		})
 		return
 	}
 	log.Printf("created X-chain export transaction %s in %s", exportTx.ID(), time.Since(exportStartTime))
@@ -472,10 +452,6 @@ func (w *workload) issueXToPTransfer(ctx context.Context) {
 	)
 	if err != nil {
 		log.Printf("failed to issue P-chain import transaction: %s", err)
-		assert.Unreachable("failed to issue P-chain import transaction", map[string]any{
-			"worker": w.id,
-			"err":    err,
-		})
 		return
 	}
 	log.Printf("created P-chain import transaction %s in %s", importTx.ID(), time.Since(importStartTime))
@@ -536,10 +512,6 @@ func (w *workload) issuePToXTransfer(ctx context.Context) {
 	)
 	if err != nil {
 		log.Printf("failed to issue P-chain export transaction: %s", err)
-		assert.Unreachable("failed to issue P-chain export transaction", map[string]any{
-			"worker": w.id,
-			"err":    err,
-		})
 		return
 	}
 	log.Printf("created P-chain export transaction %s in %s", exportTx.ID(), time.Since(exportStartTime))
@@ -551,10 +523,6 @@ func (w *workload) issuePToXTransfer(ctx context.Context) {
 	)
 	if err != nil {
 		log.Printf("failed to issue X-chain import transaction: %s", err)
-		assert.Unreachable("failed to issue X-chain import transaction", map[string]any{
-			"worker": w.id,
-			"err":    err,
-		})
 		return
 	}
 	log.Printf("created X-chain import transaction %s in %s", importTx.ID(), time.Since(importStartTime))
@@ -581,12 +549,6 @@ func (w *workload) confirmXChainTx(ctx context.Context, tx *xtxs.Tx) {
 		client := avm.NewClient(uri, "X")
 		if err := avm.AwaitTxAccepted(client, ctx, txID, 100*time.Millisecond); err != nil {
 			log.Printf("failed to confirm X-chain transaction %s on %s: %s", txID, uri, err)
-			assert.Unreachable("failed to determine the status of an X-chain transaction", map[string]any{
-				"worker": w.id,
-				"txID":   txID,
-				"uri":    uri,
-				"err":    err,
-			})
 			return
 		}
 		log.Printf("confirmed X-chain transaction %s on %s", txID, uri)
@@ -600,12 +562,6 @@ func (w *workload) confirmPChainTx(ctx context.Context, tx *ptxs.Tx) {
 		client := platformvm.NewClient(uri)
 		if err := platformvm.AwaitTxAccepted(client, ctx, txID, 100*time.Millisecond); err != nil {
 			log.Printf("failed to determine the status of a P-chain transaction %s on %s: %s", txID, uri, err)
-			assert.Unreachable("failed to determine the status of a P-chain transaction", map[string]any{
-				"worker": w.id,
-				"txID":   txID,
-				"uri":    uri,
-				"err":    err,
-			})
 			return
 		}
 		log.Printf("confirmed P-chain transaction %s on %s", txID, uri)
@@ -631,12 +587,6 @@ func (w *workload) verifyXChainTxConsumedUTXOs(ctx context.Context, tx *xtxs.Tx)
 		)
 		if err != nil {
 			log.Printf("failed to fetch X-chain UTXOs on %s: %s", uri, err)
-			assert.Unreachable("failed to fetch X-chain UTXOs", map[string]any{
-				"worker": w.id,
-				"txID":   txID,
-				"uri":    uri,
-				"err":    err,
-			})
 			return
 		}
 
@@ -677,12 +627,6 @@ func (w *workload) verifyPChainTxConsumedUTXOs(ctx context.Context, tx *ptxs.Tx)
 		)
 		if err != nil {
 			log.Printf("failed to fetch P-chain UTXOs on %s: %s", uri, err)
-			assert.Unreachable("failed to fetch P-chain UTXOs", map[string]any{
-				"worker": w.id,
-				"uri":    uri,
-				"txID":   txID,
-				"err":    err,
-			})
 			return
 		}
 

diff --git a/tests/antithesis/xsvm/main.go b/tests/antithesis/xsvm/main.go
@@ -176,12 +176,6 @@ func (w *workload) confirmTransferTx(ctx context.Context, tx *status.TxIssuance)
 		client := api.NewClient(uri, w.chainID.String())
 		if err := api.AwaitTxAccepted(ctx, client, w.key.Address(), tx.Nonce, PollingInterval); err != nil {
 			log.Printf("worker %d failed to confirm transaction %s on %s: %s", w.id, tx.TxID, uri, err)
-			assert.Unreachable("failed to confirm transaction", map[string]any{
-				"worker": w.id,
-				"txID":   tx.TxID,
-				"uri":    uri,
-				"err":    err,
-			})
 			return
 		}
 	}