Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename GetPeerList and PeerList messages #3128

Open
StephenButtolph opened this issue Jun 18, 2024 · 2 comments · May be fixed by #3133 or #3182
Open

Rename GetPeerList and PeerList messages #3128

StephenButtolph opened this issue Jun 18, 2024 · 2 comments · May be fixed by #3133 or #3182
Assignees
@MukulKolpe
Labels
cleanup Code quality improvement good first issue Good for newcomers

Comments

@StephenButtolph
Copy link
Contributor

get_peerlist and peerlist messages often treat peerlist like a single word. Whereas all the other messages get_accepted, pull_query, ect, are named consistently.

We should rename get_peerlist to get_peers.
We should rename peerlist to peers.

This will also impact some CLI flags, as peer-list options should become peers options.
@StephenButtolph StephenButtolph added good first issue Good for newcomers cleanup Code quality improvement labels Jun 18, 2024
@MukulKolpe
Copy link

Hey @StephenButtolph, can I work on this issue?

@StephenButtolph
Copy link
Contributor Author

@MukulKolpe Absolutely! If you have any questions feel free to ping here

@MukulKolpe MukulKolpe linked a pull request Jun 20, 2024 that will close this issue
Open
@won-js won-js linked a pull request Jul 9, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MukulKolpe MukulKolpe

Labels
cleanup Code quality improvement good first issue Good for newcomers
Projects
Platform Engineering Group
Status: In Progress 🏗
Milestone
No milestone
2 participants
@StephenButtolph @MukulKolpe