Rename GetPeerList and PeerList messages
#3133
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MukulKolpe
changed the title
GetPeerList and PeerList messages
Comment on lines
214
to
216
| case GetPeerListOp: | ||
| return "get_peerlist" | ||
| return "get_peers" | ||
| case PeerListOp: |
There was a problem hiding this comment.
I think there are still a number of places in the code that reference PeerLists. These op types are an example, but I think a number of places in the network package need to be renamed as well as the p2p proto
There was a problem hiding this comment.
@MukulKolpe were you still planning on working on this?
|
This PR has become stale because it has been open for 30 days with no activity. Adding the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3128
Why this should be merged
This change ensures consistency in message naming conventions, aligning
get_peerlistandpeerlistwith other message names such asget_acceptedandpull_query. It improves readability and maintains uniformity across the codebase.How this works
get_peerlistis renamed toget_peers.peerlistis renamed topeers.peer-listoptions topeersoptions.How this was tested