Honor AllowPrivateIPs config #1422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenButtolph
added
bug
joshua-kim
approved these changes
Apr 26, 2023
|
We should also add a regression test for this |
StephenButtolph
commented
Apr 26, 2023
StephenButtolph
added
the
DO NOT MERGE
StephenButtolph
removed
the
DO NOT MERGE
ceyonur
reviewed
Apr 26, 2023
ceyonur
approved these changes
Apr 26, 2023
joshua-kim
added a commit
to joshua-kim/avalanchego
that referenced
this pull request
Apr 27, 2023
commit b11e9bb Author: Stephen Buttolph <stephen@avalabs.org> Date: Wed Apr 26 14:30:28 2023 -0400 Update BLS signature ordering to avoid public key compression (ava-labs#1416) commit e44ef23 Author: Stephen Buttolph <stephen@avalabs.org> Date: Wed Apr 26 11:57:39 2023 -0400 Honor AllowPrivateIPs config (ava-labs#1422) commit 6fb00b9 Author: Stephen Buttolph <stephen@avalabs.org> Date: Wed Apr 26 11:56:46 2023 -0400 Simplify IP status calculation (ava-labs#1421)
joshua-kim
pushed a commit
to joshua-kim/avalanchego
that referenced
this pull request
Apr 28, 2023
Co-authored-by: Stephen <stephen@avalabs.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Resolves #1415
How this works
If the node is configured to skip connecting to private IPs we should never dial private IPs. It is important not to modify the
shouldDialresult frompeerIPStatusbecause that is critical to how the peerlist gossip reduction functions. (We still want to ACK the peerlist, but we don't want to dial the IP).How this was tested
TODO: CI + added tests