Simplify tx verification #1654
Merged
Simplify tx verification #1654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenButtolph
added
vm
dhrubabasu
approved these changes
Jun 26, 2023
coffeeavax
approved these changes
Jun 26, 2023
gyuho
reviewed
Jun 26, 2023
| @@ -23,9 +21,8 @@ var ( | |||
| _ snowstorm.Tx = (*UniqueTx)(nil) | |||
| _ cache.Evictable[ids.ID] = (*UniqueTx)(nil) | |||
|
|
|||
| errMissingUTXO = errors.New("missing utxo") | |||
| errUnknownTx = errors.New("transaction is unknown") | |||
There was a problem hiding this comment.
This is a non-issue now?
tx.Tx == nil no more?
There was a problem hiding this comment.
tx.Tx can only be nil now from the UniqueTx construction in Dependencies. We don't actually use these txs in consensus anywhere (see followup to remove them: #1656) so this should be impossible to happen now (i.e. consensus only handles txs returned from ParseTx).
gyuho
approved these changes
Jun 26, 2023
joshua-kim
pushed a commit
to dshiell/avalanchego
that referenced
this pull request
Jun 26, 2023
…ce (ava-labs#1654) Co-authored-by: Stephen <stephen@avalabs.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Removes various caching layers and dead code.
RejectTx.SyntacticVerificationand moves it directly intoParseTx(before performing DB IO)SemanticVerification- if this ever fails once the node will FATAL... and we only call it once if it passes.How this works
delete moar code
How this was tested
CI