MerkleDB -- Use Maybe for proof bounds
#1657
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 22 commits
June 16, 2023 16:21
…-labs/avalanchego into merkledb-test-range-proof-invariants
added 3 commits
June 26, 2023 16:07
joshua-kim
pushed a commit
to dshiell/avalanchego
that referenced
this pull request
Jun 26, 2023
added 2 commits
June 26, 2023 16:41
added 6 commits
July 13, 2023 16:54
| @@ -49,14 +49,14 @@ const ( | |||
| // [localRootID] is the ID of the root of this range in our database. | |||
| // If we have no local root for this range, [localRootID] is ids.Empty. | |||
| type workItem struct { | |||
| start []byte | |||
| end []byte | |||
| start merkledb.Maybe[[]byte] | |||
There was a problem hiding this comment.
Would it make sense to define Maybe in a shared types package rather than just merkledb?
There was a problem hiding this comment.
I can do that in a follow up PR -- this one is already kind of huge
added 8 commits
July 18, 2023 13:12
…lanchego into merkledb-maybe-proof-bounds
added 3 commits
July 20, 2023 09:58
…lanchego into merkledb-maybe-proof-bounds
|
closing in favor of #1872 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Makes bounds easier to understand (I hope.) @StephenButtolph requested this in https://github.com/ava-labs/avalanchego/pull/1629/files#r1242345719.
How this works
Instead of interpreting
startorendhaving length 0 as meaning "no lower bound" or "no upper bound" on a range, we now useMaybe[[]byte]whereNothingmeans "no bound" andSomemeans "bound exists."How this was tested
Updating existing UT.