Cleanup anr scripts #1714
Merged
Cleanup anr scripts #1714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 76945e8.
gyuho
reviewed
Jul 18, 2023
| # | ||
| # We use "export" here instead of just setting a bash variable because we need | ||
| # to pass this flag to all child processes spawned by the shell. | ||
| export CGO_CFLAGS="-O -D__BLST_PORTABLE__" |
gyuho
approved these changes
Jul 18, 2023
StephenButtolph
approved these changes
Jul 18, 2023
StephenButtolph
added
testing
| exit 255 | ||
| fi | ||
|
|
||
| # Set the CGO flags to use the portable version of BLST |
There was a problem hiding this comment.
Why are we removing this? Don't we need it to ensure this works locally on MacOS?
There was a problem hiding this comment.
install_anr.sh includes: source "$AVALANCHE_PATH"/scripts/constants.sh which already includes:
# Set the CGO flags to use the portable version of BLST
#
# We use "export" here instead of just setting a bash variable because we need
# to pass this flag to all child processes spawned by the shell.
export CGO_CFLAGS="-O -D__BLST_PORTABLE__"
# While CGO_ENABLED doesn't need to be explicitly set, it produces a much more
# clear error due to the default value change in go1.20.
export CGO_ENABLED=1
marun
added a commit
that referenced
this pull request
Jul 19, 2023
PR #1714 factored ANR installation into a common script, but in the process removed the CGO configuration for BLST from tests.e2e.sh. The result was sporadic e2e job failure whenever the github worker vm was missing the instructions non-portable BLST required. Ensuring CGO is explicitly configured for portable BLST in tests.e2e.sh should ensure the e2e test binary can once again be built reliably.
marun
added a commit
that referenced
this pull request
Jul 19, 2023
PR #1714 factored ANR installation into a common script, but in the process removed the CGO configuration for BLST from tests.e2e.sh. The result was sporadic e2e job failure whenever the github worker vm was missing the instructions non-portable BLST required. Ensuring CGO is explicitly configured for portable BLST in tests.e2e.sh should ensure the e2e test binary can once again be built reliably.
marun
added a commit
that referenced
this pull request
Jul 19, 2023
PR #1714 factored ANR installation into a common script, but in the process removed the CGO configuration for BLST from tests.e2e.sh. The result was sporadic e2e job failure whenever the github worker vm was missing the instructions non-portable BLST required. Ensuring CGO is explicitly configured for portable BLST in tests.e2e.sh should ensure the e2e test binary can once again be built reliably.
marun
added a commit
that referenced
this pull request
Jul 19, 2023
PR #1714 factored ANR installation into a common script, but in the process removed the CGO configuration for BLST from tests.e2e.sh. The result was sporadic e2e job failure whenever the github worker vm was missing the instructions non-portable BLST required. Ensuring CGO is explicitly configured for portable BLST in tests.e2e.sh should ensure the e2e test binary can once again be built reliably.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
We currently have a duplicated code to download & install ANR.
How this works
Creates a new script to install ANR and uses it in test scripts.
How this was tested
Tests should pass.