Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for providing tracing headers #1727

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Conversation

StephenButtolph
Copy link
Contributor

Why this should be merged

Allows exporting traces to uptrace without requiring code changes.

How this works

Uptrace requires providing a secret using the uptrace-dsn header.

How this was tested

When running the simple uptrace demo: https://github.com/uptrace/uptrace/tree/master/example/docker

avalanchego --tracing-enabled=true --tracing-endpoint="localhost:14317" --tracing-exporter-type=grpc --tracing-sample-rate=1 --tracing-headers="uptrace-dsn"="http://project2_secret_token@localhost:14317/2"

Results in ingesting traces:

image

@StephenButtolph StephenButtolph added the enhancement New feature or request label Jul 18, 2023
@StephenButtolph StephenButtolph added this to the v1.10.5 milestone Jul 18, 2023
@StephenButtolph StephenButtolph self-assigned this Jul 18, 2023
@StephenButtolph StephenButtolph merged commit b9355c1 into dev Jul 18, 2023
13 checks passed
@StephenButtolph StephenButtolph deleted the tracing-headers branch July 18, 2023 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants