Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove vm.state re-assignment in tests #1739

Merged
merged 2 commits into from
Jul 20, 2023
Merged

remove vm.state re-assignment in tests #1739

merged 2 commits into from
Jul 20, 2023

Conversation

dhrubabasu
Copy link
Contributor

@dhrubabasu dhrubabasu commented Jul 20, 2023 •
edited
Loading

Why this should be merged

We re-assign vm.state which is never done during normal operation and can cause races.

How this works

Remove the re-assignment.

How this was tested

CI

@dhrubabasu dhrubabasu self-assigned this Jul 20, 2023
@dhrubabasu dhrubabasu added testing This primarily focuses on testing cleanup Code quality improvement labels Jul 20, 2023
@dhrubabasu dhrubabasu added this to the v1.10.6 milestone Jul 20, 2023
@StephenButtolph StephenButtolph merged commit 5721899 into dev Jul 20, 2023
12 checks passed
@StephenButtolph StephenButtolph deleted the dont-reassign-vm-state branch July 20, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abi87 abi87 abi87 approved these changes

@StephenButtolph StephenButtolph StephenButtolph approved these changes

@danlaine danlaine Awaiting requested review from danlaine

Assignees

@dhrubabasu dhrubabasu

Labels
cleanup Code quality improvement testing This primarily focuses on testing
Projects
No open projects
Ski Patrol
Archived in project
Milestone
v1.10.7
Development

Successfully merging this pull request may close these issues.
3 participants
@dhrubabasu @abi87 @StephenButtolph