Removes calls to ctrl.Finish #1803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darioush
requested review from
danlaine,
dboehm-avalabs,
hexfusion,
StephenButtolph,
abi87,
coffeeavax and
ceyonur
as code owners
joshua-kim
approved these changes
Aug 2, 2023
hexfusion
approved these changes
Aug 2, 2023
StephenButtolph
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Removes unneeded code to make tests easier to read.
How this works
@joshua-kim found out that since go1.14+ it's not needed to call
defer ctrl.Finish()if you passtto the controller initialization. Docs: https://pkg.go.dev/github.com/golang/mock/gomock#Controller.FinishThe gomock library uses the
t.Cleanup()pattern instead.How this was tested
UTs