Ensure consistent use of best-practice set -o in all scripts

[marun]

Why this should be merged

Ensures all scripts set the following best-practice bash options:

set -o errexit # Ensure script failure on error. Without it execution continues in most cases (excepting some explicit conditional checks).
set -o nounset # Ensures an error when an unset variable is referenced (i.e. requires explicit variable initialization).
set -o pipefail # Ensures an error when a pipe call (both with `|` and `$( )`) fails.

For simplicity the set -euo pipefail one-liner is used to ensure that any future changes to the standard settings can target a single line.

[joshua-kim]

I think these changes look good, but would it make sense for us to just source a common header script that ran all these common flags instead?

[marun]

I think these changes look good, but would it make sense for us to just source a common header script that ran all these common flags instead?

Good call, I'll update accordingly.

[marun]

I switched to set -euo pipefail which is a one-liner that does the same thing as the previous 3 lines. Should simplify maintenance and is arguably simpler than ensuring that all scripts import a common file (due to scripts being potentially being run with different working directories.

[marun]

Have to fix the upgrade test script, it isn't yet compatible. Done