Add Throttled Handler implementation to SDK #1906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-kim
requested review from
danlaine,
darioush,
dboehm-avalabs,
abi87,
gyuho,
hexfusion,
StephenButtolph and
ceyonur
as code owners
joshua-kim
force-pushed
the
sdk-throttler
branch
from
769f41e
to
7eefc43
Compare
hexfusion
reviewed
Aug 25, 2023
joshua-kim
force-pushed
the
sdk-throttler-handler
branch
from
aadb94b
to
3dc9d81
Compare
Co-authored-by: Ceyhun Onur <ceyhun.onur@avalabs.org> Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
darioush
approved these changes
Aug 29, 2023
Co-authored-by: Darioush Jalali <darioush.jalali@avalabs.org> Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
abi87
reviewed
Aug 29, 2023
network/p2p/throttled_handler.go
Outdated
|
|
||
| func (t ThrottledHandler) AppGossip(ctx context.Context, nodeID ids.NodeID, gossipBytes []byte) error { | ||
| if !t.Throttler.Handle(nodeID) { | ||
| return fmt.Errorf("dropping message from %s: %w", nodeID, ErrThrottled) |
There was a problem hiding this comment.
q: should we really return an error when throttling? How about logging a warn and return nil. Not sure how AppGossip errors are handled by consensus engine
There was a problem hiding this comment.
This is dropped and logged by the p2p.responder that wraps all p2p.Handler instances. Currently we log, but in the future we'll implement application-level errors in #1889 where we'll make a custom p2p.AppError type that the sdk will interpret as an error.
Not sure how AppGossip errors are handled by consensus engine
Any AppHandler error will fatal consensus which is why they are logged, learned this when making the SDK. 😓
joshua-kim
force-pushed
the
sdk-throttler-handler
branch
from
4c3a490
to
76885a1
Compare
This reverts commit 8d9bf22.
joshua-kim
force-pushed
the
sdk-throttler-handler
branch
from
85fb3d2
to
4a1cd30
Compare
StephenButtolph
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Adds a throttled app handler implementation to the SDK
How this works
All incoming requests need to clear a throttler
How this was tested
Added unit test