Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: Switch assertion library from gomega to testify #1909

Merged
merged 13 commits into from
Sep 20, 2023

Conversation

marun
Copy link
Contributor

@marun marun commented Aug 23, 2023

Why this should be merged

Ensures the same assertion library is used for e2e as is used for unit testing.

TODO

@marun marun added the testing This primarily focuses on testing label Aug 24, 2023
@marun marun self-assigned this Aug 24, 2023
@marun marun force-pushed the e2e-switch-to-testify branch 5 times, most recently from e4b4dbe to 23f26d0 Compare August 28, 2023 00:46
@marun marun marked this pull request as ready for review September 5, 2023 23:45
@marun marun marked this pull request as draft September 6, 2023 00:02
@marun marun force-pushed the e2e-switch-to-testify branch 2 times, most recently from 7a6f74b to af3a13e Compare September 6, 2023 00:27
@marun marun marked this pull request as ready for review September 7, 2023 01:17
@StephenButtolph StephenButtolph added this to the v1.10.11 milestone Sep 20, 2023
@StephenButtolph StephenButtolph merged commit d569635 into dev Sep 20, 2023
16 checks passed
@StephenButtolph StephenButtolph deleted the e2e-switch-to-testify branch September 20, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing This primarily focuses on testing
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants