merkledb -- nits
#1916
Merged
merkledb -- nits
#1916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danlaine
commented
Aug 24, 2023
Comment on lines
-10
to
-11
| // batch is a write-only database that commits changes to its host database | ||
| // when Write is called. |
There was a problem hiding this comment.
This is documented on database.Batch so no need to do it here
danlaine
commented
Aug 24, 2023
| type batch struct { | ||
| database.BatchOps | ||
|
|
||
| db *merkleDB | ||
| } | ||
|
|
||
| // apply all operations in order to the database and write the result to disk | ||
| func (b *batch) Write() error { |
There was a problem hiding this comment.
This is documented on database.Batch so no need to do it here
danlaine
commented
Aug 24, 2023
Comment on lines
+79
to
+80
| // - When the changes in [proof.KeyChanes] are applied, | ||
| // the root ID of the database is [expectedEndRootID]. |
There was a problem hiding this comment.
proof.KeyValues and proof.DeletedKeys no longer exist
danlaine
commented
Aug 24, 2023
Comment on lines
+983
to
+984
| // This is defined on merkleDB instead of ChangeProof | ||
| // because it accesses database internals. |
dboehm-avalabs
approved these changes
Aug 24, 2023
darioush
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Cleanup
How this works
Comments
How this was tested
N/A