Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add contexts to SDK callbacks #1977

Merged
merged 6 commits into from
Sep 8, 2023
Merged

Add contexts to SDK callbacks #1977

merged 6 commits into from
Sep 8, 2023

Conversation

joshua-kim
Copy link
Contributor

@joshua-kim joshua-kim commented Sep 6, 2023 •
edited
Loading

Why this should be merged

resolves #1976

How this works

Wires the VM's context into the SDK callbacks

How this was tested

Added unit test

@joshua-kim joshua-kim changed the base branch from master to dev September 6, 2023 19:07
@joshua-kim joshua-kim self-assigned this Sep 6, 2023
@joshua-kim joshua-kim added the sdk This involves SDK tooling or frameworks label Sep 6, 2023
abi87
abi87 reviewed Sep 6, 2023
View reviewed changes
Copy link
Contributor

@abi87 abi87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, once static analysis complaints are solved

abi87
abi87 approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@abi87 abi87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a nit in tests

@StephenButtolph StephenButtolph added this to the v1.10.10 milestone Sep 8, 2023
@StephenButtolph StephenButtolph merged commit 95b5453 into ava-labs:dev Sep 8, 2023
14 of 15 checks passed
danlaine pushed a commit that referenced this pull request Sep 11, 2023
Squashed commit of the following:
2d8fd12 
commit 95b5453
Author: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
Date:   Fri Sep 8 15:59:57 2023 -0400

    Add contexts to SDK callbacks (#1977)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darioush darioush darioush approved these changes

@abi87 abi87 abi87 approved these changes

@StephenButtolph StephenButtolph StephenButtolph approved these changes

@danlaine danlaine Awaiting requested review from danlaine

@dboehm-avalabs dboehm-avalabs Awaiting requested review from dboehm-avalabs

@gyuho gyuho Awaiting requested review from gyuho

@marun marun Awaiting requested review from marun

@hexfusion hexfusion Awaiting requested review from hexfusion

Assignees

@joshua-kim joshua-kim

Labels
sdk This involves SDK tooling or frameworks
Projects
No open projects
Ski Patrol
Archived in project
Milestone
v1.10.10
Development

Successfully merging this pull request may close these issues.

Add context.Context to SDK callbacks
4 participants
@joshua-kim @darioush @abi87 @StephenButtolph